edit_prediction_button: Fix Copilot menu not updating after sign out #38854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The edit prediction button menu was displaying stale authentication status due to capturing the Copilot status in a closure. After signing out, the menu would still show "Sign Out" instead of "Sign In to Copilot". This change fixes the issue by reading the current Copilot status each time the menu is displayed, ensuring the menu options are always accurate. Signed-off-by: Xiaobo Liu <[email protected]>
cla-bot
bot
added
the
cla-signed
|
Inside the closure, due to the use of the |
SomeoneToIgnore
added
the
ai
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edit prediction button menu was displaying stale authentication status due to capturing the Copilot status in a closure. After signing out, the menu would still show "Sign Out" instead of "Sign In to Copilot".
This change fixes the issue by reading the current Copilot status each time the menu is displayed, ensuring the menu options are always accurate.
Release Notes: