Handwritten asm build prep, add handwritten asm for the code segment #1807
+614
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tack.s, add handwritten asm for the code segment
hensldm
added
code
Needs-second-approval
hensldm
reviewed
Apr 19, 2025
AngheloAlf
reviewed
Apr 21, 2025
Comment on lines
+648
to
+649
| $(BUILD_DIR)/src/makerom/ipl3.o: $(EXTRACTED_DIR)/incbin/ipl3 | ||
| $(OBJCOPY) -I binary -O elf32-big --rename-section .data=.text $< $@ |
There was a problem hiding this comment.
What's the advantage of using objcopy over incbin assembly files?
There was a problem hiding this comment.
incbin isn't supported by IDO, so we'd need custom makefile rule anyway. At that point, objcopy is simpler
hensldm
approved these changes
May 24, 2025
Dragorn421
reviewed
May 24, 2025
|
|
||
| #define _MIPS_SIM_ABI32 1 /* MIPS MSIG calling convention */ | ||
| #define _MIPS_SIM_NABI32 2 /* MIPS new 32-bit abi */ | ||
| /* NABI32 is 64bit calling convention but 32bit type sizes) */ |
There was a problem hiding this comment.
there's an open parenthesis missing?
|
|
||
| .section .text | ||
| #define PAD_TO 0x60 | ||
| #define LA(reg, sym) la reg, sym |
There was a problem hiding this comment.
Probably to be synced with OoT's entry
https://github.com/zeldaret/oot/blob/f7073a7837de95ac72a0189c74ffa96335280f12/src/makerom/entry.s#L7-L18
There was a problem hiding this comment.
makes sense
(you see and forget 👴)
hensldm
added
the
Waiting-for-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.