Skip to content

Add Zemismart Roller Blind id: tze200 68nvbio9 #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 15, 2022

Conversation

ryanturnersmith
Copy link
Contributor

@ryanturnersmith ryanturnersmith commented Feb 13, 2022

This PR will add support for device id _TZE200_68nvbio9 - Zemismart blind roller

Fixes #1348

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (23a1669) to head (c36e7a6).
Report is 703 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1349   +/-   ##
=======================================
  Coverage   81.00%   81.00%           
=======================================
  Files         217      217           
  Lines        6017     6017           
=======================================
  Hits         4874     4874           
  Misses       1143     1143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1836475912

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.004%

Totals Coverage Status
Change from base Build 1769099255: 0.0%
Covered Lines: 4874
Relevant Lines: 6017

💛 - Coveralls

@ryanturnersmith ryanturnersmith changed the title Ryanturnersmith tze200 68nvbio9 Add Zemismart Roller Blind id: tze200 68nvbio9 Feb 13, 2022
@MattWestb
Copy link
Contributor

MattWestb commented Feb 13, 2022

Looks great !!
Put one link to the issue with the device request so can see what was sad and done like this #1348 also possible putting it like this:
Fixes #1348 and the issue is being closed then the PR is being merged.

Great work done !!

@ryanturnersmith
Copy link
Contributor Author

ryanturnersmith commented Feb 13, 2022

Fixes issue #1348

@MattWestb
Copy link
Contributor

MattWestb commented Feb 13, 2022

The last i think (= not knowing) need being in the opening post and then its working its being added in the upper right side.
Look how is done in #1315

@dmulcahey dmulcahey merged commit 9373dc9 into zigpy:dev Feb 15, 2022
@ryanturnersmith ryanturnersmith deleted the ryanturnersmith-_TZE200_68nvbio9 branch February 25, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] Add device id for Zemismart Roller
5 participants