Skip to content

Use new zigpy request kwarg format #3410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Oct 9, 2024

Proposed change

Once zigpy/zigpy#1481 is merged, unit tests in this repo will start failing. This PR fixes them and ensures that we will have an easier time fixing them in the future, once we add new kwargs to the request method.

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.71%. Comparing base (fa0d9fa) to head (b589828).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
zhaquirks/eurotronic/__init__.py 50.00% 2 Missing ⚠️
zhaquirks/__init__.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3410      +/-   ##
==========================================
- Coverage   88.72%   88.71%   -0.02%     
==========================================
  Files         306      306              
  Lines        9813     9820       +7     
==========================================
+ Hits         8707     8712       +5     
- Misses       1106     1108       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES mentioned this pull request Oct 14, 2024
3 tasks
This version changes the default for `expect_reply` to `True`.
The version in `requirements_test.txt` is also bumped. This isn't really required here, but aligns it with the one in `pyproject.toml`.
@TheJulianJES
Copy link
Collaborator

Bumped the minimum required zigpy version to 0.68.1 now.
0.68.0 should be fine as well, but I guess this avoids any potential future test issues with request and expect_reply=False on 0.68.0.

This PR should be good to go then, right?

@puddly puddly marked this pull request as ready for review October 16, 2024 00:03
@puddly
Copy link
Contributor Author

puddly commented Oct 16, 2024

Yes. Coverage isn't 100% because I had to edit a few methods that weren't tested.

@TheJulianJES TheJulianJES merged commit a29ad2f into zigpy:dev Oct 16, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants