Fix status bar menu keyboard accessibility#152
Open
ethaneng wants to merge 3 commits intoBarutSRB:mainfrom
Open
Fix status bar menu keyboard accessibility#152ethaneng wants to merge 3 commits intoBarutSRB:mainfrom
ethaneng wants to merge 3 commits intoBarutSRB:mainfrom
Conversation
added 3 commits
March 22, 2026 11:38
Replace the custom NSMenu popup with an anchored panel so keyboard navigation, focus restoration, and custom visuals can coexist. Add focused tests for the menu view model and update the Ghostty clipboard callback glue so the package still builds with the restored local framework.
Adapt the upstream status bar appearance regression to the new hosted SwiftUI panel menu so the rebased accessibility branch stays green on current main.
Only intercept unmodified menu navigation keys so VoiceOver and other accessibility keyboard chords continue to pass through the status bar panel. Add a regression test covering modified arrow and space shortcuts.
Owner
|
@ethaneng Nice I'll take a look at it, thank you for taking the time to contribute and improve Omni ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tries to fix: #131
Admittedly helped by some AI tools as I don't write swift, but testing locally seems to work. Raising this for others to review and potentially use as a starting point if any proper Swift dev wants to do a tidy up.
NSMenupopup with an anchored status bar panel so the menu can keep its custom visuals while supporting real keyboard handling