Not possible to manipulate gql parser validation rules

[janisbiz]

Problem

with release of v0.17.76 it is not possible to add/remove custom validators for schema.

Analysis

long story short - this change was introduced. It always initializes a new slice with fixed pre-defined rules to be added when validating schema. This is basically fully locking out any customization for developers when they want to add or remove any rule from defaults defined by vektah/gqlparser

Workaround

there is no way to workaround it. If developers were relying on their own custom rules and/or if they were removing some of pre-defined rules & if they have tests for these scenarios - they would either fail now or developers are not aware of this functionality silently getting broken

Proposal

Expose rules variable so developers can manipulate them based on their needs

OR

Use initialized validator with all it supported methods for adding/removing rules

[StevenACoffman]

Hi! Sorry for any inconvenience. The intent was quite the opposite of what you describe. The old use of global variables made it difficult for GraphQL validation rules to be manipulated. For instance, gqlgen users wanted to be able to validate internal requests differently from external requests, which was previously impossible.

Your linked change is not particularly granular in pointing out the specific change, or how you are having trouble adapting to it.

In #3751 the change was made to accommodate these gqlparser changes:

• Refactoring: not to use global rule sets (part 1) vektah/gqlparser#379
• Refactoring: not to use global rule sets (part 2) vektah/gqlparser#380
• BREAKING: Fix AddRule and ReplaceRule methods behavior and add documentation vektah/gqlparser#381

[janisbiz]

Hi @StevenACoffman,

as I stated in Analysis section:

long story short - this change was introduced. It always initializes a new slice with fixed pre-defined rules to be added when validating schema. This is basically fully locking out any customization for developers when they want to add or remove any rule from defaults defined by vektah/gqlparser

right now there is no way using 99designs/gqlgen to use any of methods offered by vektah/gqlparser, as pretty much all validators are privately "hardcoded" in the change.

Exact code which is fully internal & not exposed for developers to manipulate, paying attention to currentRules := rules.NewDefaultRules() where NewDefaultRules is always initialized with "static list" thus afterwards - due to variable of currentRules being private within function - there is no way for anyone to change any rule.

If I am wrong, please share a code snippet on how can I modify(add/remove/replace) rules.

[StevenACoffman]

I did not mean to imply that you were incorrect.

I added a comment last night to the PR where the change was made:
#3751 (comment)

I think that we would need to add an alternative mechanism:

	if e.defaultRulesFn == nil {
		e.defaultRulesFn = rules.NewDefaultRules
	}
	currentRules := e.defaultRulesFn()

When this is on:

// Executor executes graphql queries against a schema.
type Executor struct {
	es         graphql.ExecutableSchema
	extensions []graphql.HandlerExtension
	ext        extensions

	errorPresenter graphql.ErrorPresenterFunc
	recoverFunc    graphql.RecoverFunc
	queryCache     graphql.Cache[*ast.QueryDocument]

	parserTokenLimit  int
	disableSuggestion bool
	defaultRulesFn    func() *rules.Rules
}

However, we need to expose options to set this further up.

[StevenACoffman]

Please see:
#3772