Skip to content

Add server GraphQL rules customization#3779

Merged
StevenACoffman merged 1 commit intomasterfrom
server_customize_rules
Jul 28, 2025
Merged

Add server GraphQL rules customization#3779
StevenACoffman merged 1 commit intomasterfrom
server_customize_rules

Conversation

@StevenACoffman
Copy link
Copy Markdown
Collaborator

@StevenACoffman StevenACoffman commented Jul 28, 2025

Follow-up to #3772, Fixes #3771 so that it is possible to customize the GraphQL Validation rules in the server

In #3751 the change was made to accommodate these gqlparser changes:

However, because the GraphQL Validation rules are set to gqlparser's default rules, it's not easy (or obvious how) to use custom validation rules. This PR at least provides a mechanism on the Executor to alter the Validation Rules so you can use customized rules.

Signed-off-by: Steve Coffman steve@khanacademy.org

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 28, 2025

Coverage Status

coverage: 72.728% (-0.04%) from 72.771%
when pulling 9062788 on server_customize_rules
into 051c306 on master.

Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman StevenACoffman force-pushed the server_customize_rules branch from bac1e2a to 9062788 Compare July 28, 2025 13:43
@StevenACoffman
Copy link
Copy Markdown
Collaborator Author

@janisbiz @g1ntas @laurynas-k, please take a look and see if this meets your needs or if you have any other suggestions or feedback.

@StevenACoffman StevenACoffman merged commit de496cf into master Jul 28, 2025
19 checks passed
@StevenACoffman StevenACoffman deleted the server_customize_rules branch July 28, 2025 13:48
@janisbiz
Copy link
Copy Markdown

janisbiz commented Jul 28, 2025

Hi @StevenACoffman!

Looks good, thank you. Will be waiting for it to be in a release version, tested by using replace in go.mod of your commit.

@StevenACoffman
Copy link
Copy Markdown
Collaborator Author

StevenACoffman commented Sep 14, 2025

@janisbiz this is now released 🥳

Sorry for the long delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not possible to manipulate gql parser validation rules

3 participants