Description
There are some issues with the quadplane tilt down rate for tilt-enabled quadplanes.
- the quadplane.assisted_flight flag oscillates during the TRANSITION_TIMER phase of the fwd transition
- if Q_TRANSITION_MS is smaller than the time it takes to go from Q_TILT_MAX to full tilt with the configured Q_TILT_RATE parameters then the last part will happen at 90 deg/s
- when we complete the transition there can be a sudden throttle change on the tilted motors, much faster than the THR_SLEWRATE should allow
assisted_flight oscillation
The assisted flight flag oscillates as SLT_Transition::update() will set it to false once airspeed is reached due to should_assist() returning false. It then gets set back to true in the TRANSITION_TIMER further down in the same function. The impact is not significant, but it is confusing.
too fast slew
If Q_TRANSITION_MS is smaller than the time it takes to go from Q_TILT_MAX to full tilt then the last part of the tilt will happen at 90 deg/s due to the fast_tilt logic and TRANSITION_TIMER no longer being true. Possibly we should stay in TRANSITION_TIMER until the full tilt is reached?
instant throttle change
when the transition has completed and the VTOL motors are turned off the tilted motors move from VTOL tilt control to fwd throttle control. When this happens the throttle changes instantly and the sudden throttle change can disturb the aircraft pitch as the pitch PID does not have time to compensate.