WIP: AP_UAVCAN_DNA: add CANH health logging message #20586
Conversation
|
It will be great to add further Error parameters of a CAN Periph. further to this idea is to also log CAN BUS status. |
| if we haven't logged this node then log it now | ||
| */ | ||
| if (!logged_CANH.get(node_id) && AP::logger().logging_started()) { | ||
| logged_CANH.set(node_id); |
There was a problem hiding this comment.
simplest way to make it handle a single dropped pkt without logging an error is to only log the error if the bit is already set in logged_CANH when the failure happens.
also, logged_CANH needs to be unset when we do get a good reply
that way we'll log unhealthy when 2 pkts are no replied to in a row, but mark healthy when one reply is received
| // @Description: CAN Health Status | ||
| // @Field: TimeUS: Time since system startup | ||
| // @Field: NodeId: Node ID | ||
| // @Field: Healthy |
There was a problem hiding this comment.
need description of @field Healthy
tridge
force-pushed
the
pr/add_CANH_log_field
branch
from
70aa878 to
f1952d3
Compare
|
rebased and fixed CI error |
we do have some of that in @sys filesystem at the moment, but I agree on adding logging |
tridge
force-pushed
the
pr/add_CANH_log_field
branch
2 times, most recently
from
548a261 to
ca4ebc8
Compare
tridge
force-pushed
the
pr/add_CANH_log_field
branch
from
ca4ebc8 to
759ed2c
Compare
|
@hendjoshsr71 re-worked this with @Lokesh-Carbonix to add an option to log all NodeStatus pkts. When diagnosing issues I think this is the most useful option |
tridge
force-pushed
the
pr/add_CANH_log_field
branch
from
759ed2c to
57632fb
Compare
Co-authored-by: Lokesh-Carbonix <[email protected]>
tridge
force-pushed
the
pr/add_CANH_log_field
branch
from
57632fb to
13ea23a
Compare
@Lokesh-Carbonix
Untested!!!
WIP demo to add a CANH healthy message to log NodeStatus info. and gather when a node disconnects
Co-authored-by: Lokesh-Carbonix [email protected]