-
Notifications
You must be signed in to change notification settings - Fork 19k
Fixes for AM32 Passthrough #29056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for AM32 Passthrough #29056
Conversation
47572a6
to
d6ce676
Compare
@MichelleRos could you test this on Nessie? It should make the am32.ca configurator more reliable with ArduPilot |
or have you tested @Huibean ? |
I have tested it, still some issue with am32.ca, I am adding firmware flash test to my config python script to confirm |
2024.01.21 test update
using https://github.com/Huibean/am32_config first run
second run
|
@Huibean with the fw upload failure with this PR, does it also fail with master? |
Master should have issue enter the MSP pass through mode |
Yeah @tridge master is more broken. Its not clear to me that anything is broken now with this PR apart from the web configurator |
don't cache connection result and return appropriate error if connection fails. don't wait 1s to send first serial passthrough message retry failed cmd_DeviceInitFlash as per betaflight ensure the bootinfo structure is large enough
only configure DMA on groups that are actually being used for soft serial
d6ce676
to
78d13fb
Compare
Although not directly related the AP AM32 DroneCAN ESC page includes instructions on how to update the firmware and set parameters using MP's DroneCAN page https://ardupilot.org/copter/docs/common-am32-escs.html |
I think this should be considered for 4.6 |
This is included in AP-4.6.0-beta4 |
Fixes some issues seen on AM32 passthrough. Tested on AM32 and BLHeli32