AP_BattMonitor: add Copter brake/land failsafe action to parameter me… #29361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. Just for accountability it looks like:
|
rmackay9
approved these changes
Feb 24, 2025
|
Yeh, that was my bad. In my defince I noticed the missing battery failsafe and asked Peter if it should have also been added to the battery. When I read through the code it looks like the failsafes are more seperated than they really are. What confused me is the hash defines: And then there are no battery ones at all. It took some going back and forth before I felt confident it was missing. |
|
I was unable to immediately include this in 4.6.0-beta5 due to merge conflicts |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tadata