Skip to content

AP_Motors: fixed motor knocking issue on tilt quadplanes #29518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tridge
Copy link
Contributor

@tridge tridge commented Mar 13, 2025

the motor output was happening twice per loop with different values for tilt quadplanes using motor matrix

not tested yet

the motor output was happening twice per loop with different values
for tilt quadplanes using motor matrix
@IamPete1
Copy link
Member

We do output PWM twice, but its after a cork and before a push, so I don't understand how its getting out to the motors.

@IamPete1
Copy link
Member

I have added the same fix for the tri-copter backend.

@IamPete1
Copy link
Member

Apparently this does fix, but I still don't understand the cork push thing.

@IamPete1
Copy link
Member

To be clear, I don't think we should merge this without understanding it. I also think there may be is a issue with how motor_enabled_mask is set, because we do the normal output first then the throttle override it must be 0 on the first call. We should test the tailsitter case too which is the other user of the motor_enabled_mask stuff.

@tridge
Copy link
Contributor Author

tridge commented Mar 13, 2025

@IamPete1 I think this is a better fix:
#29521

@rmackay9 rmackay9 mentioned this pull request Mar 13, 2025
94 tasks
@tridge
Copy link
Contributor Author

tridge commented Mar 19, 2025

went with cork/push fix

@tridge tridge closed this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants