AP_Camera: mavlink commands use target sysid and compid #30517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies ArduPilto's AP_Camera MAVLinkV2 backend so that it specifies the camera's sysid and compid when sending commands instead of using the broadcast address (e.g. sysid=0, compid=0).
This issue was discovered while testing the AirPixel TAG-E but will also affect the Gremsy camera gimbals with built-in cameras (e.g. the ZIO).
Without this fix, we can be sure that two mavlink enabled cameras will not work correctly because both cameras will likely respond to the broadcast messages. In fact, the TAG-E does not current accept the commands unless this fix is made.
BTW there are 4 commands that the driver may send within COMMAND_LONG messages:
This has been confirmed to work by Tag-E