Skip to content

AP_Camera: mavlink commands use target sysid and compid #30517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

rmackay9
Copy link
Contributor

@rmackay9 rmackay9 commented Jul 1, 2025

This modifies ArduPilto's AP_Camera MAVLinkV2 backend so that it specifies the camera's sysid and compid when sending commands instead of using the broadcast address (e.g. sysid=0, compid=0).

This issue was discovered while testing the AirPixel TAG-E but will also affect the Gremsy camera gimbals with built-in cameras (e.g. the ZIO).

Without this fix, we can be sure that two mavlink enabled cameras will not work correctly because both cameras will likely respond to the broadcast messages. In fact, the TAG-E does not current accept the commands unless this fix is made.

BTW there are 4 commands that the driver may send within COMMAND_LONG messages:

This has been confirmed to work by Tag-E

Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterbarker peterbarker merged commit 0788fe6 into ArduPilot:master Jul 2, 2025
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants