Skip to content

fix: byok test needs to wait longer for node creation#1346

Merged
rakechill merged 13 commits intomainfrom
rakechill/byok-debug
Jan 12, 2026
Merged

fix: byok test needs to wait longer for node creation#1346
rakechill merged 13 commits intomainfrom
rakechill/byok-debug

Conversation

@rakechill
Copy link
Copy Markdown
Contributor

@rakechill rakechill commented Jan 10, 2026

Description
The BYOK e2e test is flaky, especially for the managed case.

There were two main issues observed:

  1. env.ExpectCreatedNodeCount("==", 1) --> env.EventuallyExpectCreatedNodeCount("==", 1)
  2. pod healthiness check needs to come after node count check

During debugging, I also determined that By statements make readability of the test logs a bit easier, so I added those, too. Open to removing if others prefer.

This change will need to be included in the latest release tag (if possible) after merge.

How was this change tested?

  • managed + self-hosted e2e. will link a self-hosted run shortly.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@rakechill
Copy link
Copy Markdown
Contributor Author

rakechill commented Jan 10, 2026

Copy link
Copy Markdown
Contributor Author

@rakechill rakechill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test byok

Copy link
Copy Markdown
Collaborator

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rakechill rakechill merged commit 47c1c6b into main Jan 12, 2026
20 of 21 checks passed
@rakechill rakechill deleted the rakechill/byok-debug branch January 12, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants