Skip to content

fix: byok test needs to wait longer for node creation #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rakechill merged 13 commits into from
Jan 12, 2026
Merged

fix: byok test needs to wait longer for node creation #1346

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e2cbc89
Increase timeout for pod health check to 15 minutes
rakechill Jan 2, 2026
d0d7489
Focus on 1st testcase only
rakechill Jan 2, 2026
a609e22
Reorder health check expectation in suite_test.go
rakechill Jan 2, 2026
a9812bd
Increase timeout for pod health check to 15 minutes for first testcase
rakechill Jan 2, 2026
469d1ea
update suite_test to use By() statements
rakechill Jan 9, 2026
b0bba91
add logs to help debug
rakechill Jan 9, 2026
7d598c5
Node should eventually be provisioned
rakechill Jan 9, 2026
52e447c
wait for pod to be healthy before checking vm fields
rakechill Jan 10, 2026
2cbc910
Remove logging statements
rakechill Jan 10, 2026
40313af
simplify byok test to only include fix and remove ai markdown files
rakechill Jan 10, 2026
c98614f
remove a few extra changes from refactor
rakechill Jan 10, 2026
76ba27d
remove a few extra unnecessary changes
rakechill Jan 10, 2026
28f0b6c
Merge branch 'main' into rakechill/byok-debug
rakechill Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions test/suites/byok/suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,27 +67,39 @@ var _ = Describe("BYOK", func() {
It("should provision a VM with customer-managed key disk encryption", func() {
ctx := context.Background()
var diskEncryptionSetID string

By("Phase 1: Setting up DES (Disk Encryption Set)")
// If not InClusterController, assume the test setup will include the creation of the KV, KV-Key + DES
if env.InClusterController {
diskEncryptionSetID = CreateKeyVaultAndDiskEncryptionSet(ctx, env)
env.ExpectSettingsOverridden(corev1.EnvVar{Name: "NODE_OSDISK_DISKENCRYPTIONSET_ID", Value: diskEncryptionSetID})
}

By("Phase 2: Creating NodeClass and NodePool")
nodeClass := env.DefaultAKSNodeClass()
nodePool := env.DefaultNodePool(nodeClass)

By("Phase 3: Creating test Pod")
pod := test.Pod()

By("Applying resources to Kubernetes")
env.ExpectCreated(nodeClass, nodePool, pod)

By("Phase 4: Waiting for VM to be created and node to be registered")
env.EventuallyExpectCreatedNodeCount("==", 1)

By("Phase 5: Verifying Pod becomes healthy")
env.EventuallyExpectHealthy(pod)
env.ExpectCreatedNodeCount("==", 1)

By("Phase 6: Verifying VM disk encryption configuration")
vm := env.GetVM(pod.Spec.NodeName)
Expect(vm.Properties).ToNot(BeNil())
Expect(vm.Properties.StorageProfile).ToNot(BeNil())
Expect(vm.Properties.StorageProfile.OSDisk).ToNot(BeNil())
Expect(vm.Properties.StorageProfile.OSDisk.ManagedDisk).ToNot(BeNil())
Expect(vm.Properties.StorageProfile.OSDisk.ManagedDisk.DiskEncryptionSet).ToNot(BeNil())
Expect(vm.Properties.StorageProfile.OSDisk.ManagedDisk.DiskEncryptionSet.ID).ToNot(BeNil())

if env.InClusterController {
Expect(lo.FromPtr(vm.Properties.StorageProfile.OSDisk.ManagedDisk.DiskEncryptionSet.ID)).To(Equal(diskEncryptionSetID))
}
Expand All @@ -96,38 +108,51 @@ var _ = Describe("BYOK", func() {
It("should provision a VM with ephemeral OS disk and customer-managed key disk encryption", func() {
ctx := context.Background()
var diskEncryptionSetID string

By("Phase 1: Setting up DES (Disk Encryption Set)")
// If not InClusterController, assume the test setup will include the creation of the KV, KV-Key + DES
if env.InClusterController {
diskEncryptionSetID = CreateKeyVaultAndDiskEncryptionSet(ctx, env)
env.ExpectSettingsOverridden(corev1.EnvVar{Name: "NODE_OSDISK_DISKENCRYPTIONSET_ID", Value: diskEncryptionSetID})
}

By("Phase 2: Creating NodeClass with ephemeral disk configuration")
nodeClass := env.DefaultAKSNodeClass()
nodePool := env.DefaultNodePool(nodeClass)

By("Phase 3: Configuring ephemeral OS disk requirement")
test.ReplaceRequirements(nodePool, karpv1.NodeSelectorRequirementWithMinValues{
NodeSelectorRequirement: corev1.NodeSelectorRequirement{
Key: v1beta1.LabelSKUStorageEphemeralOSMaxSize,
Operator: corev1.NodeSelectorOpGt,
Values: []string{"50"},
}})

nodeClass.Spec.OSDiskSizeGB = lo.ToPtr[int32](50)

By("Phase 4: Creating test Pod")
pod := test.Pod()

By("Applying resources to Kubernetes")
env.ExpectCreated(nodeClass, nodePool, pod)

By("Phase 5: Waiting for VM to be created and node to be registered")
env.EventuallyExpectCreatedNodeCount("==", 1)

By("Phase 6: Verifying Pod becomes healthy")
env.EventuallyExpectHealthy(pod)
env.ExpectCreatedNodeCount("==", 1)

By("Phase 7: Verifying VM disk configuration")
vm := env.GetVM(pod.Spec.NodeName)
Expect(vm.Properties).ToNot(BeNil())
Expect(vm.Properties.StorageProfile).ToNot(BeNil())
Expect(vm.Properties.StorageProfile.OSDisk).ToNot(BeNil())

By("Phase 8: Verifying ephemeral OS disk settings")
Expect(vm.Properties.StorageProfile.OSDisk.DiffDiskSettings).ToNot(BeNil())
Expect(vm.Properties.StorageProfile.OSDisk.DiffDiskSettings.Option).ToNot(BeNil())
Expect(string(lo.FromPtr(vm.Properties.StorageProfile.OSDisk.DiffDiskSettings.Option))).To(Equal("Local"))

By("Phase 9: Verifying DES is configured on managed disk")
Expect(vm.Properties.StorageProfile.OSDisk.ManagedDisk).ToNot(BeNil())
Expect(vm.Properties.StorageProfile.OSDisk.ManagedDisk.DiskEncryptionSet).ToNot(BeNil())
Expect(vm.Properties.StorageProfile.OSDisk.ManagedDisk.DiskEncryptionSet.ID).ToNot(BeNil())
Expand Down
Loading