Fix PR push times #420

mark-i-m · 2017-05-31T01:06:11Z

Currently if you push on a different branch on your fork, it will reset the time for all PRs from that fork, even if they are completely unrelated. This issue aims to fix that.

PlasmaPower · 2017-05-31T02:36:07Z

@mark-i-m Please fix the tests.

mark-i-m · 2017-05-31T02:40:52Z

Working on it :)

PlasmaPower · 2017-05-31T02:50:45Z

Still not fixed :(

If you could also expand the tests to with and without events present, that'd be great.

PlasmaPower · 2017-05-31T02:51:04Z

and I'm assuming you know this, but you can run the tests locally of course.

mark-i-m · 2017-05-31T02:53:57Z

Hmm... I am actually having trouble running them locally... which is why I am doing a lot of guessing...

mark-i-m · 2017-05-31T02:54:13Z

What things do I need to pip install to run them locally?

andrewda · 2017-05-31T02:55:07Z

Now it's just a linting issue 😝

andrewda · 2017-05-31T02:55:44Z

tests/github_api/prs_test.py

+                "pushed_at": pushed_at,
+                "name": "test_repo",
+            },
+            "ref" : "test_ref"


Remove space after "ref"

mark-i-m · 2017-05-31T02:56:45Z

If you could also expand the tests to with and without events present, that'd be great.

First, I need to figure out how the testing harness works... 😛

PlasmaPower · 2017-05-31T03:02:11Z

@mark-i-m

pip install -r requirements.txt
python -m unittest

pip might need root/admin, depending on your setup.

PlasmaPower

I would still appreciate tests for the event driven code, but I approve this PR as it stands

mark-i-m · 2017-05-31T03:21:55Z

Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/lib/python2.7/unittest/__main__.py", line 12, in <module>
    main(module=None)
  File "/usr/lib/python2.7/unittest/main.py", line 94, in __init__
    self.parseArgs(argv)
  File "/usr/lib/python2.7/unittest/main.py", line 149, in parseArgs
    self.createTests()
  File "/usr/lib/python2.7/unittest/main.py", line 158, in createTests
    self.module)
  File "/usr/lib/python2.7/unittest/loader.py", line 130, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/lib/python2.7/unittest/loader.py", line 91, in loadTestsFromName
    module = __import__('.'.join(parts_copy))
  File "github_api/__init__.py", line 7, in <module>
    import settings
  File "settings.py", line 2, in <module>
    import misc
  File "misc.py", line 2, in <module>
    from urllib.parse import urlparse
ImportError: No module named parse```

andrewda

Also would like some tests if possible, but this looks good 👍

PlasmaPower · 2017-05-31T03:25:01Z

@mark-i-m Python 3.6? If so, our requirements.txt might be off. I'll look into it.

mark-i-m · 2017-05-31T03:26:48Z

Ah, that's true... ubuntu 16.04 only has python 3.5.2... Is there any way to run this in the docker container?

PlasmaPower · 2017-05-31T03:27:23Z

@mark-i-m No idea, and that Python version might not even be a problem, IDK.

PlasmaPower · 2017-05-31T04:50:56Z

github_api/prs.py

+        # if we can't get good data, fall back to repo push time
+        repo = pr_data["head"]["repo"]
+        if repo:
+            return arrow.get(repo["pushed_at"])


I think we want to max this with pr_data["created_at"] too.

Hmmm... then how did it work before?

I mean, it makes sense

It didn't work. A number of PRs got insta-closed and one got insta-merged before the threshold increase.

PlasmaPower · 2017-05-31T04:54:56Z

I need to sleep... will finish this up tomorrow

Sleep... nah

anythingbot · 2017-05-31T05:46:14Z

@PlasmaPower actually, I think you will be doing yourself and the project a favor if you sleep as much as you want (which may be none for all I know).

Video game developers try to figure out how to get your consciousness to experience new sensations that create excitement and stimulate the full range of sensation. The idea is to get your brain to ride a chemical high while immersed in the game world.

If you want to check this out, you can search "gamasutra flow" or "gamasutra addiction" for endless discussions of the interactions of social networks and the learning process. There you will find various articles about groups of video game developers who spend countless hours trying to create in simulation what these "learning bots" or "democracy bots" or "neuron bots" do naturally. So far these have been the chaosbot and botwillacceptanything. There may be others, I don't know.

The chaosbot builds its own social network. This means the leaders of the social network take on amounts of stress that are well in excess of what any individual (or even self aware group) intends because the group is going through a profound transformation process of becoming self-aware.

What winds up happening is complex. There is a positive reinforcement learning (this is HUMAN learning, not machine learning; it is YOUR learning process that is being reinforced) mechanism that quite frankly turns interaction with the bot into a highly addictive "virtual drug" much more potent than any mere game, since the bot could quite easily be the back-end power behind a massively multiplayer online game.

I've personally found strength in the words of Edward Bernays, who wrote this about democracy and leadership in "The Engineering of Consent". The drive to understand the will of the community can be a powerful motivator as well as a source of great stress.

Leaders may be the spokesmen for
many different points of view. They
may direct the activities of major organized
groups such as industry, labor,
or units of government. They may
compete with one another in battles for
public good will; or they may, representing
divisions within the larger units,
compete among themselves. Such leaders,
with the aid of technicians in the
field who have specialized in utilizing
the channels of communication, have
been able to accomplish purposefully
and scientifically what we have termed
"the engineering of consent."

THE ENGINEERING APPROACH

This phrase quite simply means the
use of an engineering approach—that is,
action based only on thorough knowledge
of the situation and on the application
of scientific principles and tried
practices to the task of getting people
to support ideas and programs. Any
person or organization depends ultimately
on public approval, and is therefore
faced with the problem of engineering
the public's consent to a program
or goal. We expect our elected
government officials to try to engineer
our consent—through the network of
communications open to them—for the
measures they propose. We reject government
authoritarianism or regimentation,
but we are willing to take action
suggested to us by the written or
spoken word. The engineering of consent
is the very essence of the democratic
process, the freedom to persuade
and suggest. The freedoms of speech,
press, petition, and assembly, the freedoms
which make the engineering of
consent possible, are among the most
cherished guarantees of the Constitution
of the United States.
The engineering of consent should be
based theoretically and practically on
the complete understanding of those
whom it attempts to win over. But it
is sometimes impossible to reach joint
decisions based on an understanding of
facts by all the people. The average
American adult has only six years of
schooling behind him. With pressing
crises and decisions to be faced, a leader
frequently cannot wait for the people
to arrive at even general understanding.
In certain cases, democratic leaders
must play their part in leading the public
through the engineering of consent
to socially constructive goals and values.
This role naturally imposes upon them
the obligation to use the educational
processes, as well as other available
techniques, to bring about as complete
an understanding as possible

mdcfe · 2017-05-31T05:48:54Z

/essay
😛

andrewda · 2017-05-31T05:55:19Z

wow @anythingbot good read 👍 (guess I should probably sleep now 💤 )

mdcfe · 2017-05-31T05:56:48Z

~~Meanwhile, in the UK...~~

…r_date

mark-i-m · 2017-06-01T00:57:20Z

Can anyone decipher the error on that last failing test?

mark-i-m · 2017-06-01T01:09:29Z

Nvm... got it 🎉

PlasmaPower · 2017-06-01T01:10:31Z

@mark-i-m I realized the patches were getting mixed up - never would have guess it needs to be in reverse order.

mark-i-m · 2017-06-01T01:11:08Z

Yeah, that's pretty unintuitive

PlasmaPower · 2017-06-01T01:11:24Z

Looks like that arg line is a bit too long.

PlasmaPower · 2017-06-01T01:14:51Z

@mark-i-m Wrong line - it's the arg line of the test we were working on.

PlasmaPower

Looks good! 🎉

chaosbot · 2017-06-01T04:47:08Z

🙆‍♀️ PR passed with a vote of 18 for and 0 against, a weighted total of 17.5 and a threshold of 6.5, and a current meritocracy review.

See merge-commit 9dabaf3 for more details.

mark-i-m added 4 commits May 30, 2017 21:02

Don't reset timer for unrelated pushes

dff9d45

Merge branch 'master' into fix_pr_date

8af4b6c

bug fixes

9e692ac

removed debugging code

eb9c97b

PlasmaPower approved these changes May 31, 2017

View reviewed changes

lint

86ee2db

andrewda approved these changes May 31, 2017

View reviewed changes

Merge branch 'master' into fix_pr_date

59eed0a

Fixed test?

1e99e75

fixing tests this time?

95dfe81

andrewda requested changes May 31, 2017

View reviewed changes

lint

de493ed

PlasmaPower approved these changes May 31, 2017

View reviewed changes

Attempt 1 at tests (I still can't get these to run locally)

5b21b7b

andrewda approved these changes May 31, 2017

View reviewed changes

lint

3e2902e

bug fix

2f1f522

Fix tests

5b75484

PlasmaPower reviewed May 31, 2017

View reviewed changes

mark-i-m added 5 commits May 31, 2017 19:33

Merge branch 'master' of https://github.com/chaosbot/Chaos into fix_p…

7c65607

…r_date

Fix comment

a270653

bug fix

048a5b8

Apparently this makes a difference

13ef07c

One last test failing

6d8579f

Fixed at last

33a0a5d

lint

999ae57

lint for realz this time

f24dbae

PlasmaPower approved these changes Jun 1, 2017

View reviewed changes

mark-i-m changed the title ~~[WIP] Fix PR push times~~ Fix PR push times Jun 1, 2017

mark-i-m mentioned this pull request Jun 1, 2017

Sometimes a PR is immediately accepted/rejected #199

Closed

phil-r mentioned this pull request Jun 1, 2017

Bring back mandatory travis-ci check #412

Merged

6 tasks

chaosbot merged commit 9dabaf3 into Chaosthebot:master Jun 1, 2017

chaosbot added the accepted label Jun 1, 2017

This was referenced Jun 2, 2017

Use symbol emojis instead of human emojis #472

Merged

Voting window resets on push to any branch #147

Closed

Fix PR push times #420

Fix PR push times #420

Uh oh!

Conversation

mark-i-m commented May 31, 2017

Uh oh!

PlasmaPower commented May 31, 2017

Uh oh!

mark-i-m commented May 31, 2017

Uh oh!

PlasmaPower commented May 31, 2017

Uh oh!

PlasmaPower commented May 31, 2017

Uh oh!

mark-i-m commented May 31, 2017

Uh oh!

mark-i-m commented May 31, 2017

Uh oh!

andrewda commented May 31, 2017

Uh oh!

andrewda May 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mark-i-m commented May 31, 2017

Uh oh!

PlasmaPower commented May 31, 2017

Uh oh!

PlasmaPower left a comment

Choose a reason for hiding this comment

Uh oh!

mark-i-m commented May 31, 2017

Uh oh!

andrewda left a comment

Choose a reason for hiding this comment

Uh oh!

PlasmaPower commented May 31, 2017

Uh oh!

mark-i-m commented May 31, 2017

Uh oh!

PlasmaPower commented May 31, 2017

Uh oh!

PlasmaPower May 31, 2017

Choose a reason for hiding this comment

Uh oh!

mark-i-m May 31, 2017

Choose a reason for hiding this comment

Uh oh!

mark-i-m May 31, 2017

Choose a reason for hiding this comment

Uh oh!

PlasmaPower May 31, 2017

Choose a reason for hiding this comment

Uh oh!

PlasmaPower commented May 31, 2017

Uh oh!

anythingbot commented May 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdcfe commented May 31, 2017

Uh oh!

andrewda commented May 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdcfe commented May 31, 2017

Uh oh!

mark-i-m commented Jun 1, 2017

Uh oh!

mark-i-m commented Jun 1, 2017

Uh oh!

PlasmaPower commented Jun 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mark-i-m commented Jun 1, 2017

Uh oh!

PlasmaPower commented Jun 1, 2017

Uh oh!

PlasmaPower commented Jun 1, 2017

Uh oh!

PlasmaPower left a comment

andrewda May 31, 2017 •

edited

Loading

anythingbot commented May 31, 2017 •

edited

Loading

andrewda commented May 31, 2017 •

edited

Loading

PlasmaPower commented Jun 1, 2017 •

edited

Loading