Skip to content

Use symbol emojis instead of human emojis #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chaosbot merged 1 commit into from
Jun 2, 2017
Merged

Use symbol emojis instead of human emojis #472

chaosbot merged 1 commit into from
Jun 2, 2017

Conversation

@PlasmaPower
Copy link
Contributor

@PlasmaPower PlasmaPower commented Jun 2, 2017 •
edited
Loading

When I'm glancing through emails, I have to look closely to see what 🙆‍♀️ and 🙅 are. It'd be a lot easier with ⛔ and ✅. The different colors make it a lot clearer.

@rhengles
Copy link
Member

rhengles commented Jun 2, 2017

Personally, I prefer more 🆗 or ✅ than 🎉 .

@PlasmaPower
Copy link
Contributor Author

PlasmaPower commented Jun 2, 2017 •
edited
Loading

@rhengles ✅ looks like a good choice. Changed.

Thoughts on the stale PR with merge conflicts emoji? It was 🙅. I changed it to 💔 as it's a bit different than ⛔. I'm reconsidering that though. Which does everyone else prefer?

@PlasmaPower
Copy link
Contributor Author

PlasmaPower commented Jun 2, 2017

@andrewda Re-review needed after change

@mark-i-m
Copy link
Contributor

mark-i-m commented Jun 2, 2017

@PlasmaPower Have you just been stockpiling PRs?

@PlasmaPower
Copy link
Contributor Author

PlasmaPower commented Jun 2, 2017

@mark-i-m I stockpile ideas, then sometimes I feel like doing stuff.

@PlasmaPower
Copy link
Contributor Author

PlasmaPower commented Jun 2, 2017 •
edited
Loading

I have chaosbot's full attention - literally all the PRs it is processing right now are mine 😄.

@mark-i-m
Copy link
Contributor

mark-i-m commented Jun 2, 2017

Shameless plug: #420

@PlasmaPower
Copy link
Contributor Author

PlasmaPower commented Jun 2, 2017

@mark-i-m yeah I'm really appreciating that right now.

@PlasmaPower
Copy link
Contributor Author

PlasmaPower commented Jun 2, 2017 •
edited
Loading

Now includes stalled CI failed message (recently merged).

@chaosbot chaosbot merged commit 2970afc into Chaosthebot:master Jun 2, 2017
@chaosbot
Copy link
Collaborator

chaosbot commented Jun 2, 2017

🙆‍♀️ PR passed with a vote of 10 for and 0 against, a weighted total of 10.0 and a threshold of 6.5, and a current meritocracy review.

See merge-commit 2970afc for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhengles rhengles rhengles approved these changes

@andrewda andrewda andrewda approved these changes

@o3LL o3LL o3LL approved these changes

Assignees

No one assigned

Labels

accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@PlasmaPower @rhengles @mark-i-m @chaosbot @andrewda @o3LL