Skip to content

fix: use proper iterations times and fix round sizes #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

art049
Copy link
Member

@art049 art049 commented Jan 28, 2025

  • fix: use time per iteration instead of total round time in stats
  • feat: increase the min round time to a bigger value (+/- 1ms)

@art049 art049 force-pushed the cod-505-use-correct-timings-in-pytest-codspeed-walltime branch from 5468412 to 325cb00 Compare January 28, 2025 11:09
@art049 art049 requested a review from adriencaccia January 28, 2025 11:09
Copy link

codspeed-hq bot commented Jan 28, 2025

CodSpeed Instrumentation Performance Report

Merging #67 will improve performances by 3.05%

Comparing cod-505-use-correct-timings-in-pytest-codspeed-walltime (4333c1f) with master (003c3b4)

Summary

⚡ 1 improvements
✅ 46 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_combination_lists[5-4] 28.7 µs 27.9 µs +3.05%

Copy link

codspeed-hq bot commented Jan 28, 2025

CodSpeed Walltime Performance Report

Merging #67 will degrade performances by 3.83%

Comparing cod-505-use-correct-timings-in-pytest-codspeed-walltime (4333c1f) with master (003c3b4)

Summary

⚡ 36 improvements
❌ 1 regressions
✅ 10 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iir_filter_process 3 µs 2.7 µs +12.36%
test_iir_filter_set_coefficients[a_coeffs0-b_coeffs0] 852 ns 638.3 ns +33.48%
test_make_allpass 5.2 µs 4.6 µs +14.09%
test_make_bandpass 5.5 µs 4.9 µs +12.19%
test_make_highpass 5.7 µs 5 µs +13.35%
test_make_highshelf 7.4 µs 6.4 µs +14.08%
test_make_lowpass 5.7 µs 5 µs +14%
test_make_lowshelf 7.2 µs 6.4 µs +13.58%
test_make_peak 6.4 µs 5.6 µs +14.28%
test_color[graph0-3] 27.1 µs 26.2 µs +3.71%
test_combination_lists[0-0] 1.9 µs 1.5 µs +28.08%
test_combination_lists[4-2] 3.6 µs 3.4 µs +7.74%
test_combination_lists[5-4] 3.4 µs 3 µs +12.55%
test_combination_sum[candidates0-8] 9.1 µs 8.7 µs +4.14%
test_generate_all_combinations[0-0] 1,212 ns 864.4 ns +40.21%
test_generate_all_combinations[4-2] 5.9 µs 5.7 µs +3.85%
test_generate_all_combinations[5-4] 8.2 µs 7.9 µs +4.53%
test_generate_all_subsequences[sequence1] 91.9 µs 90.1 µs +2.04%
test_generate_parenthesis[3] 7.8 µs 7.5 µs +3.84%
test_get_valid_pos[pos0-4] 2.8 µs 2.4 µs +16.22%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@adriencaccia
Copy link
Member

Let's merge #65 before this one, so that the reports will work correctly

@art049 art049 force-pushed the cod-505-use-correct-timings-in-pytest-codspeed-walltime branch 2 times, most recently from 3c67c78 to 4333c1f Compare January 31, 2025 14:11
@art049 art049 merged commit 4333c1f into master Jan 31, 2025
36 checks passed
@art049 art049 deleted the cod-505-use-correct-timings-in-pytest-codspeed-walltime branch January 31, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants