Fix regression in FamilyType.ByGeometry Node #3066
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is to fix a regression in the FamilyType.ByGeometry node. Specifically a change in the Revit API behavior with
Delete(elementID)
method is causing the node to throw an exception. This is regression between Revit 2024 and Revit 2025 API behavior. In this case the D4R code temporarily imports an SAT file to get geometry to use in the FamilyType creation. The code deletes the SAT import once the geometry has been converted to a Revit Solid. The Revit API change in behavior impacts the ability toDelete
the SAT import. The workaround is to unpin the imported Element so that the Delete will not throw.While there are many use of the
Delete
element method in the D4R code, it appears the behavior change is limited to the SAT import.Declarations
Check these if you believe they are true
*.resx
filesReviewers
@mjkkirschner @sm6srw
FYIs
@Mikhinja