Skip to content

Fix regression in FamilyType.ByGeometry Node #3066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

saintentropy
Copy link
Contributor

Purpose

This PR is to fix a regression in the FamilyType.ByGeometry node. Specifically a change in the Revit API behavior with Delete(elementID) method is causing the node to throw an exception. This is regression between Revit 2024 and Revit 2025 API behavior. In this case the D4R code temporarily imports an SAT file to get geometry to use in the FamilyType creation. The code deletes the SAT import once the geometry has been converted to a Revit Solid. The Revit API change in behavior impacts the ability to Delete the SAT import. The workaround is to unpin the imported Element so that the Delete will not throw.

While there are many use of the Delete element method in the D4R code, it appears the behavior change is limited to the SAT import.

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • Snapshot of UI changes, if any.

Reviewers

@mjkkirschner @sm6srw

FYIs

@Mikhinja

@sm6srw
Copy link
Contributor

sm6srw commented Apr 30, 2024

LGTM.

@mjkkirschner mjkkirschner self-requested a review April 30, 2024 21:05
@saintentropy saintentropy merged commit 5e55ee9 into DynamoDS:RC3.0.3_Revit2025 Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants