Fix regression in FamilyType.ByGeometry Node #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

saintentropy merged 2 commits into DynamoDS:master from saintentropy:REVIT-220887CP

Apr 30, 2024

Contributor

saintentropy commented Apr 30, 2024

Purpose

Cherry pick of #3066 PR to the Revit2025 branch.

Declarations

Check these if you believe they are true

The code base is in a better state after this PR
Is documented according to the standards
The level of testing this PR includes is appropriate
User facing strings, if any, are extracted into *.resx files
Snapshot of UI changes, if any.

Reviewers

@mjkkirschner @sm6srw

FYIs

saintentropy added 2 commits

April 30, 2024 13:57


          CP fix for FamilyType.ByGeometry

235ec41


          Update version / changelog

32d1747

Contributor

sm6srw commented Apr 30, 2024

This is for 2026, right?

Contributor

sm6srw commented Apr 30, 2024

LGTM!

mjkkirschner approved these changes

View reviewed changes

saintentropy merged commit f2e5ff2 into DynamoDS:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet