Rollback search fields to list and dynamically compute md5 hash in tests
#311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
approved these changes
Aug 30, 2024
| @@ -81,12 +81,11 @@ def read_from_string(self, data: str | bytes) -> BaseModel | SupportsPickle: | |||
|
|
|||
|
|
|||
| class SearchIndex: | |||
|
|
|||
| REQUIRED_FIELDS: ClassVar[set[str]] = {"file_location", "body"} | |||
| REQUIRED_FIELDS: ClassVar[list[str]] = ["file_location", "body"] | |||
There was a problem hiding this comment.
set is still a Sequence, let's keep this as a set to enforce uniqueness
There was a problem hiding this comment.
I see what you're saying but set isn't a Sequence, it's a Collection, right?
There was a problem hiding this comment.
I think a Collection is a subset of Sequence, unless I am missing something
There was a problem hiding this comment.
Other way around I think: https://docs.python.org/3/library/collections.abc.html#collections-abstract-base-classes
… and keep consistent hashes; aded env vars to test.yaml
… a log level failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sidnarayanan found a couple of issues while testing: