Recursive directory indexing; catch indexing errors #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add agentic workflow module and cli * update pyproject.toml and split google into its own import * remove unused import * update default search chain * Update __init__.py * Update search.py * move reqs into pyproject.toml, addressing PR comments * rename search_chain to openai_get_search_query * remove get_llm_name * move table_formatter to helpers.py * Update paperqa/agents/main.py Co-authored-by: James Braza <[email protected]> * Update paperqa/agents/main.py Co-authored-by: James Braza <[email protected]> * Update paperqa/agents/main.py Co-authored-by: James Braza <[email protected]> * Update paperqa/agents/docs.py Co-authored-by: James Braza <[email protected]> * Update paperqa/types.py Co-authored-by: James Braza <[email protected]> * rename compute_cost to compute_total_model_token_cost * remove stream_answer * rename to stub_manifest, and use Path for all paths * Update paperqa/llms.py Co-authored-by: James Braza <[email protected]> * move SKIP_AGENT_TESTS = False * nix _ = assignments * add test comments * types in conftest.py * split libs into llms * link openai chat timeout to query.timeout * Update paperqa/agents/__init__.py Co-authored-by: James Braza <[email protected]> * logging revamp and renaming * Update tests/test_cli.py Co-authored-by: James Braza <[email protected]> * Update tests/test_cli.py Co-authored-by: James Braza <[email protected]> * move vertex import to func call, add docstring to SupportsPickle * docstring * remove _ = * remove bool return type from set * update gitignore * add config attribute to baase LLMModel class * replace get_current_settings -> get_settings * replace get_current_settings -> get_settings * PR simplifications * remove all stream_* functions * avoid modifying the root logger * re-organize logger import location * move hashlib into utils * refactor strip_answer into Answer object * label circular imports * ensure absolute paths are used in index name * limit select to be used only when DOI is not present in crossref * Update paperqa/agents/search.py Co-authored-by: James Braza <[email protected]> * Update paperqa/agents/search.py Co-authored-by: James Braza <[email protected]> * Update paperqa/agents/search.py Co-authored-by: James Braza <[email protected]> * Update paperqa/agents/search.py Co-authored-by: James Braza <[email protected]> * Update paperqa/agents/models.py Co-authored-by: James Braza <[email protected]> * reconfigure logging to not prevent propagation * remove newlines in the current year * use required fields as a subset * replace . with Path.cwd() --------- Co-authored-by: James Braza <[email protected]>
jamesbraza
reviewed
Aug 30, 2024
jamesbraza
approved these changes
Aug 30, 2024
|
Is this relevant @sidnarayanan ? The base PR is dead |
* add unpaywall provider * remove unused clean query method, update test cassettes to use [email protected]
sidnarayanan
force-pushed
the
recurse-directories
branch
from
888c14c to
57e73a8
Compare
|
Oh boy, this has really drifted from main. I'm going to close this PR and open a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this PR into
test-md5to make the diff easier to read. Will rebase + point to main once #311 is merged.get_directory_index(recursive: bool=True)to recursively index a directoryImpossibleParsingErrorif no text is parsed from PDFAlso lots of whitespace changes from ruff and black - they're conflicting with each other in some places.