Skip to content

Fix grid_search #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: pytorch
Choose a base branch
from
Open

Fix grid_search #1526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions alf/bin/grid_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,10 +394,7 @@ def launch_snapshot_gridsearch():
# write the current conf file as
# ``<root_dir>/alf_config.py`` or ``<root_dir>/configured.gin``
conf_file = common.get_conf_file()
if conf_file.endswith('.gin'):
# for gin, we need to parse it first. Otherwise, configured.gin will be
# empty
common.parse_conf_file(conf_file)
common.parse_conf_file(conf_file)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling parse_conf_file in the main process will create an env, which might be unnecessary or even problematic in certain cases?

common.write_config(root_dir)

# generate a snapshot of ALF repo as ``<root_dir>/alf``
Expand Down