-
-
Notifications
You must be signed in to change notification settings - Fork 235
feat: add base to default rpc networks #5902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Prithpal-Sooriya
merged 11 commits into
main
from
MMASSETS-773/add-base-enabled-by-default
Jun 5, 2025
Merged
feat: add base to default rpc networks #5902
Prithpal-Sooriya
merged 11 commits into
main
from
MMASSETS-773/add-base-enabled-by-default
Jun 5, 2025
+83
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix linting issues, update changelog, add missing constant
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
Prithpal-Sooriya
commented
Jun 3, 2025
Prithpal-Sooriya
commented
Jun 3, 2025
Prithpal-Sooriya
commented
Jun 3, 2025
This was referenced Jun 3, 2025
bergarces
previously approved these changes
Jun 4, 2025
…:MetaMask/core into MMASSETS-773/add-base-enabled-by-default
…-base-enabled-by-default
sahar-fehri
previously approved these changes
Jun 5, 2025
mikesposito
previously approved these changes
Jun 5, 2025
even though the change is implicit, I think it is worth documenting since it does have large ramifications.
cryptodev-2s
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
sahar-fehri
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This adds the Base network as a network enabled by default.
Testdrive PRs:
References
https://consensyssoftware.atlassian.net/browse/MMASSETS-773
https://consensyssoftware.atlassian.net/browse/MMASSETS-774
Changelog
Checklist