Skip to content

feat: add base to default rpc networks #5902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 5, 2025

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Jun 3, 2025

Explanation

This adds the Base network as a network enabled by default.

Testdrive PRs:

References

https://consensyssoftware.atlassian.net/browse/MMASSETS-773
https://consensyssoftware.atlassian.net/browse/MMASSETS-774

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Prithpal-Sooriya Prithpal-Sooriya requested review from a team as code owners June 3, 2025 12:30
@Prithpal-Sooriya Prithpal-Sooriya changed the title Mmassets 773/add base enabled by default feat: add base to default rpc networks Jun 3, 2025
fix linting issues, update changelog, add missing constant
@Prithpal-Sooriya Prithpal-Sooriya marked this pull request as draft June 3, 2025 12:47
@Prithpal-Sooriya
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link
Contributor

github-actions bot commented Jun 3, 2025

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "30.0.0-preview-f7d7af35",
  "@metamask-previews/address-book-controller": "6.0.3-preview-f7d7af35",
  "@metamask-previews/announcement-controller": "7.0.3-preview-f7d7af35",
  "@metamask-previews/app-metadata-controller": "1.0.0-preview-f7d7af35",
  "@metamask-previews/approval-controller": "7.1.3-preview-f7d7af35",
  "@metamask-previews/assets-controllers": "68.0.0-preview-f7d7af35",
  "@metamask-previews/base-controller": "8.0.1-preview-f7d7af35",
  "@metamask-previews/bridge-controller": "32.0.0-preview-f7d7af35",
  "@metamask-previews/bridge-status-controller": "29.0.0-preview-f7d7af35",
  "@metamask-previews/build-utils": "3.0.3-preview-f7d7af35",
  "@metamask-previews/chain-agnostic-permission": "0.7.0-preview-f7d7af35",
  "@metamask-previews/composable-controller": "11.0.0-preview-f7d7af35",
  "@metamask-previews/controller-utils": "11.9.0-preview-f7d7af35",
  "@metamask-previews/delegation-controller": "0.4.0-preview-f7d7af35",
  "@metamask-previews/earn-controller": "0.15.0-preview-f7d7af35",
  "@metamask-previews/eip1193-permission-middleware": "0.1.0-preview-f7d7af35",
  "@metamask-previews/ens-controller": "16.0.0-preview-f7d7af35",
  "@metamask-previews/error-reporting-service": "1.0.0-preview-f7d7af35",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-f7d7af35",
  "@metamask-previews/gas-fee-controller": "23.0.0-preview-f7d7af35",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-f7d7af35",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-f7d7af35",
  "@metamask-previews/keyring-controller": "22.0.1-preview-f7d7af35",
  "@metamask-previews/logging-controller": "6.0.4-preview-f7d7af35",
  "@metamask-previews/message-manager": "12.0.1-preview-f7d7af35",
  "@metamask-previews/multichain": "4.1.0-preview-f7d7af35",
  "@metamask-previews/multichain-api-middleware": "0.4.0-preview-f7d7af35",
  "@metamask-previews/multichain-network-controller": "0.8.0-preview-f7d7af35",
  "@metamask-previews/multichain-transactions-controller": "2.0.0-preview-f7d7af35",
  "@metamask-previews/name-controller": "8.0.3-preview-f7d7af35",
  "@metamask-previews/network-controller": "23.5.1-preview-f7d7af35",
  "@metamask-previews/notification-services-controller": "9.0.0-preview-f7d7af35",
  "@metamask-previews/permission-controller": "11.0.6-preview-f7d7af35",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-f7d7af35",
  "@metamask-previews/phishing-controller": "12.5.0-preview-f7d7af35",
  "@metamask-previews/polling-controller": "13.0.0-preview-f7d7af35",
  "@metamask-previews/preferences-controller": "18.1.0-preview-f7d7af35",
  "@metamask-previews/profile-sync-controller": "16.0.0-preview-f7d7af35",
  "@metamask-previews/queued-request-controller": "10.0.0-preview-f7d7af35",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-f7d7af35",
  "@metamask-previews/remote-feature-flag-controller": "1.6.0-preview-f7d7af35",
  "@metamask-previews/sample-controllers": "0.1.0-preview-f7d7af35",
  "@metamask-previews/seedless-onboarding-controller": "1.0.0-preview-f7d7af35",
  "@metamask-previews/selected-network-controller": "22.1.0-preview-f7d7af35",
  "@metamask-previews/signature-controller": "30.0.0-preview-f7d7af35",
  "@metamask-previews/token-search-discovery-controller": "3.2.0-preview-f7d7af35",
  "@metamask-previews/transaction-controller": "57.0.0-preview-f7d7af35",
  "@metamask-previews/user-operation-controller": "36.0.0-preview-f7d7af35"
}

bergarces
bergarces previously approved these changes Jun 4, 2025
sahar-fehri
sahar-fehri previously approved these changes Jun 5, 2025
mikesposito
mikesposito previously approved these changes Jun 5, 2025
@Prithpal-Sooriya Prithpal-Sooriya enabled auto-merge (squash) June 5, 2025 12:02
@Prithpal-Sooriya Prithpal-Sooriya disabled auto-merge June 5, 2025 12:02
even though the change is implicit, I think it is worth documenting since it does have large ramifications.
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Prithpal-Sooriya Prithpal-Sooriya enabled auto-merge (squash) June 5, 2025 12:13
@Prithpal-Sooriya Prithpal-Sooriya merged commit d913b90 into main Jun 5, 2025
218 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the MMASSETS-773/add-base-enabled-by-default branch June 5, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants