feat: add base network to networks enabled by default #16064
Merged
+362
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
4 tasks
Prithpal-Sooriya
added a commit
to MetaMask/core
that referenced
this pull request
Jun 5, 2025
## Explanation This adds the Base network as a network enabled by default. Testdrive PRs: - Extension: MetaMask/metamask-extension#33448 - Mobile: MetaMask/metamask-mobile#16064 ## References https://consensyssoftware.atlassian.net/browse/MMASSETS-773 https://consensyssoftware.atlassian.net/browse/MMASSETS-774 ## Changelog <!-- THIS SECTION IS NO LONGER NEEDED. The process for updating changelogs has changed. Please consult the "Updating changelogs" section of the Contributing doc for more. --> ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs), highlighting breaking changes as necessary - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
…ETS-774/enable-base-by-default
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Prithpal-Sooriya
force-pushed
the
MMASSETS-774/enable-base-by-default
branch
from
fd44b98 to
c4a96f7
Compare
app/components/Views/Settings/SecuritySettings/__snapshots__/SecuritySettings.test.tsx.snap
Show resolved
Hide resolved
app/components/Views/Settings/NetworksSettings/__snapshots__/index.test.tsx.snap
Show resolved
Hide resolved
...omponents/Views/OnboardingSuccess/OnboardingAssetsSettings/__snapshots__/index.test.tsx.snap
Show resolved
Hide resolved
|
|
gambinish
approved these changes
Jun 11, 2025
metamaskbot
added
the
release-7.50.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates network controller to support enabling base network by default.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-774
Manual testing steps
It looks like for both existing and new users base and other networks are enabled by default on mobile. We only needed to add this work for extension.
Screenshots/Recordings
Before
After
https://www.loom.com/share/9b4340fe1d22424d94b3124027e20288?sid=e481f40c-0f65-4074-b8db-d4a03783d76d
DEVLOG
https://www.loom.com/share/ad2135390ac341f8967aa630284323eb
Pre-merge author checklist
Pre-merge reviewer checklist