Remove redundant global keyword usage#1927
Merged
lgoettgens merged 1 commit intomasterfrom Dec 16, 2024
Merged
Conversation
Also constify _html_as_latex
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1927 +/- ##
=======================================
Coverage 88.27% 88.27%
=======================================
Files 119 119
Lines 30360 30360
=======================================
Hits 26800 26800
Misses 3560 3560 ☔ View full report in Codecov by Sentry. |
lgoettgens
approved these changes
Dec 16, 2024
Member
lgoettgens
left a comment
lgoettgens
left a comment
There was a problem hiding this comment.
Looks good. But please wait with merging until we had a re-run after oscar-system/Oscar.jl#4405
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also constify _html_as_latex