Repository navigation
Contain pipeline cache save allocation failures - #1046
Merged
hckrman101 merged 2 commits intoNov 9, 2026
Merged
Conversation
Keep standard exceptions in the cache export worker and recover its busy flag on every exit. Handle thread-start exceptions without changing cache thresholds, write policy or forced-wait ordering. Add actual-function allocation/thread/file regressions and isolated original-source negatives. Refs NotRexed#1022; the reported full game crash remains unconfirmed. Assisted-by: Codex Co-Authored-By: Codex <noreply@openai.com>
monsterlag
marked this pull request as draft
November 9, 2026 09:07
monsterlag
marked this pull request as ready for review
November 9, 2026 09:48
Preserve upstream runtime/build changes and automatic strict test runner. Resolve its ARGS conflict by retaining the pipeline-cache fixture plus upstream capture-copy and screensaver registrations. The production exception/busy guard and fault assertions are unchanged. Assisted-by: OpenAI Codex Co-Authored-By: OpenAI Codex <noreply@openai.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline cache saves can throw while allocating their byte buffer or temporary filename. A detached worker then terminates the process; a forced save propagates the exception and can leave the busy flag set.
Contain standard exceptions in the save worker, release the busy flag on every worker exit, and report thread-construction failures. Successful saves, thresholds and the existing forced-save behavior are preserved.
Validation on the refreshed main source:
Refs #1022. These checks use real C++ containers/threads with authored Vulkan/file responses, without a GPU, game or real pipeline cache. The refresh does not add a new renderer/game run or prove an operating-system thread/detach failure. Concurrent forced callers and the cache format retain their existing behavior. Hosted Windows renderer, Builder packaging, Linux AppImage, native F2I, SPIR-V and workflow-lint checks pass. Both source jobs fail solely on the existing answer-domain fixture tracked in #1076; the new cache-save test passes in both. See platform builds, AppImage and source checks.