Skip to content

fix: restore shader answer-domain regression fixture - #1076

Closed
nickyfactz wants to merge 1 commit into
NotRexed:mainfrom
nickyfactz:fix/shader-answer-domain-fixture
Closed

nickyfactz wants to merge 1 commit into
NotRexed:mainfrom
nickyfactz:fix/shader-answer-domain-fixture

Conversation

@nickyfactz

Copy link
Copy Markdown
Contributor

After the pipeline-state-list and answer-domain changes landed together, test_program_answer_domains.py no longer compiles: the extracted production record_answers function reads the thread-local answers_in, but the fixture did not define it. The current main source-regression run fails on both Windows and Linux.

Add the fixture's missing input and check that pipeline-state answers are retained in the recorded variant. The renderer and runtime are unchanged.

Validation:

  • Windows Clang/MSVC: reproduced the undeclared identifier on main; the focused fixture now passes its five default/strict environment cases. python -I -B tests/run_all.py --strict program_answer_domains passes.
  • WSL GCC: reproduced the same failure and verified the five cases pass after the fix, with -D_Static_assert=static_assert for the local GCC compiler.
  • A negative control that disables the production answers_in branch fails the new assertion.
  • git diff --check passes. Upstream PR checks for this commit have not run yet.

Assisted-by: OpenAI Codex

Provide the pipeline-state answer input used by the extracted matcher and check that supplied answers retain their variant.

Assisted-by: OpenAI Codex
Co-Authored-By: OpenAI Codex <noreply@openai.com>
@NotRexed

NotRexed commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Thanks! The same fix landed in dev (99e3ce0) through #1077's commit, which reads the declaration from vk_shader.cpp instead of copying it into the test, so I'm closing this one as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants