Repository navigation
fix: restore shader answer-domain regression fixture - #1076
Closed
nickyfactz wants to merge 1 commit into
Closed
nickyfactz wants to merge 1 commit into
nickyfactz wants to merge 1 commit into
Conversation
Provide the pipeline-state answer input used by the extracted matcher and check that supplied answers retain their variant. Assisted-by: OpenAI Codex Co-Authored-By: OpenAI Codex <noreply@openai.com>
This was referenced Nov 9, 2026
Owner
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the pipeline-state-list and answer-domain changes landed together,
test_program_answer_domains.pyno longer compiles: the extracted productionrecord_answersfunction reads the thread-localanswers_in, but the fixture did not define it. The current main source-regression run fails on both Windows and Linux.Add the fixture's missing input and check that pipeline-state answers are retained in the recorded variant. The renderer and runtime are unchanged.
Validation:
python -I -B tests/run_all.py --strict program_answer_domainspasses.-D_Static_assert=static_assertfor the local GCC compiler.answers_inbranch fails the new assertion.git diff --checkpasses. Upstream PR checks for this commit have not run yet.Assisted-by: OpenAI Codex