Repository navigation
Restore the answer-domain fixture after state-list replay - #1077
Closed
klimovich008 wants to merge 1 commit into
Closed
klimovich008 wants to merge 1 commit into
klimovich008 wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing in favor of #1076: it fixes the same compile failure with a simpler fixture declaration and adds coverage for supplied replay answers. Its Windows/Linux source tests and platform builds pass. One PR is enough for this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
The answer-domain regression stops compiling on Windows and Linux with
use of undeclared identifier 'answers_in'. This blocks source CI for unrelated changes after pipeline-state replay added that dependency to the function under test.Why merge
Change
tests/test_program_answer_domains.py: extract the actualanswers_indeclaration fromvk_shader.cppbefore the existing function block, afterProgramis available.Tested
python -I -B tests/run_all.py --strict: compiles the fixture and runs its existing default/strict answer-domain cases.Not covered
No game data is included.