Repository navigation
Free the space left by a failed NUP unpack - #1393
Merged
NotRexed merged 1 commit intoNov 10, 2026
Merged
Conversation
Assisted-by: OpenAI Codex Co-authored-by: Codex <codex@openai.com>
Owner
|
This landed in the v2.0.12 branch (merged there for testing; it reaches |
Owner
|
Reopened: closing this was a mistake on my side. It was tested in the v2.0.12 branch, and it will be merged into main here, so it shows as merged. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a fresh NUP unpack fails, the Builder leaves its partially written
.gamedirectory in the output folder. The next attempt deletes that staging directory before unpacking anyway.Remove the staging directory when extraction or validation fails, before the previous game cache is replaced. Keep the original build error and log the staging path if cleanup also fails.
The game-free regression simulates the Builder error from a disk-full unpack and checks that the partial data is gone and the previous cache and save are intact. It also covers a missing ROMFS and an unsupported build. The three cleanup assertions fail on
mainand pass with this change. The cache, missing-input, and output regression suites passed on Windows and Linux, and the NUP path suite passed on Linux.Related to #1388, which was closed with disk-space guidance. #1391 measures free space on the destination volume. This change frees the Builder staging space after an unsuccessful unpack.
Compatibility check: tested a clean combined tree with #1391 (destination free-space reporting) and #1395 (interrupted ROMFS copies). The cache, missing-input and output suites passed on Windows and Linux. The NUP path suite also passed on Linux.