Repository navigation
fix: keep interrupted ROMFS copies out of the destination - #1395
Merged
Merged
Conversation
Stage the fallback copy next to the destination and move it into place after the copy and metadata update succeed. Remove the temporary file on failure, including when copied metadata made it read-only on Windows. Game-free fixtures cover a disk-full failure followed by a successful retry, and a denied final replacement of a read-only file. Assisted-by: OpenAI Codex Co-Authored-By: Codex <noreply@openai.com>
Owner
|
This landed in the v2.0.12 branch (merged there for testing; it reaches |
Owner
|
Reopened: closing this was a mistake on my side. It was tested in the v2.0.12 branch, and it will be merged into main here, so it shows as merged. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Builder receives extracted ROMFS folders on a different drive, a hard link fails and it copies each asset. An interrupted copy leaves a partial file at the final path. A retry skips that path because it already exists.
Stage each fallback copy beside its destination and move it into place after the copy and metadata update succeed. Clean up failed stages, including copies that inherited a read-only attribute on Windows. Existing destination assets still follow the Builder's resume policy.
Game-free fixtures simulate a cross-volume disk-full error, then retry and check the complete asset and an existing destination file. A second test simulates a denied replacement of a read-only copy. All ten cases in
tests/test_make_game_cache.pypassed on macOS. Windows execution is pending CI.AI assistance from OpenAI Codex is recorded in the commit trailers.