Repository navigation
fix: validate cache paths before building from extracted folders - #1397
Merged
hckrman101 merged 1 commit intoNov 10, 2026
Merged
Conversation
Use the existing cache path guard for both ROMFS and retained ExeFS before copying or unpacking inputs. Extend the game-free regression to cover a Windows reparse point with both source modes. Assisted-by: OpenAI Codex Co-Authored-By: Codex <noreply@openai.com>
Owner
|
This landed in the v2.0.12 branch (merged there for testing; it reaches |
Owner
|
Reopened: closing this was a mistake on my side. It was tested in the v2.0.12 branch, and it will be merged into main here, so it shows as merged. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Builder validates the output ROMFS and retained ExeFS cache paths for NUP builds and updates. When the source is an extracted folder pair, it skips the ROMFS check and checks retained ExeFS only after it has already started copying. A redirected output ROMFS folder can therefore receive writes through a Windows junction.
Use the existing cache guard for both destinations before copying or unpacking the selected folders. The game-free regression simulates a Windows reparse point and verifies that both input modes stop before staging ExeFS or changing cached files.
python3 -I -B tests/run_all.py --strict make_game_cachepassed on macOS. This change is independent of #1395 and the two patches merge cleanly.AI assistance from OpenAI Codex is recorded in the commit trailers.