Repository navigation
fix(vk): recover presentation after surface loss - #1995
Merged
Merged
Conversation
Arkex-ai
force-pushed
the
fix/vulkan-surface-loss
branch
from
November 10, 2026 23:28
d526a52 to
c5aec41
Compare
Contributor
Author
|
Thanks for the review. The previous Windows source run matched the exact upstream base: 322 passed, 2 failed, 21 skipped, with the same log timing failure and skeleton bake timeout. The three new fork workflows are linked in the Validation table for |
Arkex-ai
force-pushed
the
fix/vulkan-surface-loss
branch
from
November 11, 2026 00:13
c5aec41 to
cda37c2
Compare
Arkex-ai
marked this pull request as ready for review
November 11, 2026 00:35
Arkex-ai
force-pushed
the
fix/vulkan-surface-loss
branch
2 times, most recently
from
November 11, 2026 11:39
01147b2 to
8c6b593
Compare
Refs NotRexed#1977 Assisted-by: GPT-6 (Codex)
Refs NotRexed#1977 Assisted-by: GPT-6 (Codex)
Refs NotRexed#1977 Assisted-by: GPT-6 (Codex)
Assisted-by: GPT-6 (OpenAI)
Arkex-ai
force-pushed
the
fix/vulkan-surface-loss
branch
from
November 11, 2026 12:43
8c6b593 to
b52079d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After Vulkan reported a lost window surface, the picture could stop indefinitely. The renderer now retires the old swapchain and retries with a replacement surface after loss during acquire, present or swapchain setup.
Closes #1977.
Technical changes
Validation
Current head:
b52079d5, rebased onto main49f75dc8(recorder test ordering fix). All authored commits are unchanged by range-diff. Fresh hosted checks run on this head; the local and native results below remain tied to their earlier tested heads.Earlier local and native evidence:
Earlier head:
8c6b593d, rebased onto mainebbba2ea. Focused Windows checks: 4 passed / 1 failed. Swapchain recovery, presentation semaphores, Anti-Lag and the new FPS statistics pass. The recorder check fails its existing destructor negative control on both this head and the exact clean base. Earlier native evidence remains labeled below.cda37c2, the upstream source suite passed with 323 passed / 0 failed / 24 skipped on Windows and 337 / 0 / 10 on Linux. Windows includes the temporary bake skips from test: log_batch "off" takes the fastest of three; bake tests skip on Windows CI (600 s limit) #2013.Earlier native smoke test and Linux surface probe
cc80fde(API 14), a Windows RTX 5070 Ti run logged 6,688 presents at 2× frame generation with pacing off. The Kokiri scene returned after maximize, restore and minimize, and the game exited normally.