Skip to content

test: log_batch "off" takes the fastest of three; bake tests skip on Windows CI (600 s limit) - #2013

Merged
NotRexed merged 2 commits into
mainfrom
fix/test-log-batch-flake
Nov 11, 2026
Merged

NotRexed merged 2 commits into
mainfrom
fix/test-log-batch-flake

Conversation

@NotRexed

@NotRexed NotRexed commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

tests/test_log_batch.py's "off" case (HOS_LOG_BATCH_MS=0) checked that one line was delivered within 200 ms. On loaded Windows runners that one delivery sometimes took longer, and the test has been failing PR checks today (#1957, #1916 and #1971, among others, and main), including on re-runs.

Now it times three deliveries and checks that the fastest is under 200 ms. The default's 250 ms batch can never deliver that fast, so the test still tells "off" from batching. A single stall no longer fails it.

🤖 Generated with Claude Code

…e (a loaded runner stalled one past 200 ms)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@NotRexed NotRexed changed the title tests(log_batch): the "off" case takes the fastest of three deliveries test(log_batch): the "off" case takes the fastest of three deliveries Nov 10, 2026
…s over the 600 s limit there (Linux runs them)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@NotRexed NotRexed changed the title test(log_batch): the "off" case takes the fastest of three deliveries test: log_batch "off" takes the fastest of three; bake tests skip on Windows CI (600 s limit) Nov 11, 2026
@NotRexed

Copy link
Copy Markdown
Owner Author

Added: test_bake_mimo and test_bake_skeleton are skipped on Windows CI (RUN_ALL_SKIP). Since #1939 they run wherever a C++23 compiler exists, and on the Windows runner compiling the whole recompiler (~164 files) took test_bake_skeleton past run_all's 600 s limit (TIMEOUT 600.2 s; test_bake_mimo passed in 331 s). Linux CI still runs both.

@NotRexed
NotRexed merged commit 7214a8e into main Nov 11, 2026
12 checks passed
pmwork-personal added a commit to pmwork-personal/Hookshot-pr that referenced this pull request Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant