Repository navigation
Invalidate translated shaders after bank changes - #793
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
A build that changes only shader constant or storage-buffer bank handling can reuse translated shaders from the old code.
vk_bank.cppaffects translation but is missing from the shader cache stamp.Why merge
Change
nx2/build.py: include"vk_bank.cpp"in the explicit translator source tuple.tests/test_shader_stamp_inputs.py: execute the production stamp block and check bank edits, unrelated draw edits and CRLF normalization.Tested
python -I -B tests/run_all.py --jobs 1 --strict shader_stamp_inputs; checks the actual hash block using tiny temporary source files.test_mem_trim.py; the unchanged current base reproduces that failure, tracked in tests: mem_trim accepts the BC3 scratch's even-size argument #799.Not covered