Repository navigation
build: avoid unrelated rebuilds when the shader translator stamp changes - #788
Merged
Merged
Conversation
Owner
|
Thanks! #793 was just merged: it adds gpu/vk/vk_bank.cpp to the shader stamp inputs, so this PR's fixture in tests/test_shader_stamp_cache.py now fails with FileNotFoundError for gpu/vk/vk_bank.cpp (10 errors). Could you rebase onto main and add vk_bank.cpp to the fixture's files? The build.py change itself looks right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The translator stamp is passed to every Vulkan renderer compilation, although only
vk_shader.cppconsumes it. Pass the existing definition only to that consumer so translator changes stop invalidating unrelated object-cache keys.Preserve upstream's bank-source input from #793, the hash/CRLF normalization, object-key construction, header dependencies and other flags. Removing the irrelevant flag causes a one-time cache-key transition; later translator or bank-only changes retain unrelated objects.
Six authored Python tests execute the actual job construction and key functions in Windows/Linux modes. They cover translator/bank changes, own-source/header invalidation, line endings and release/version flags. The current-main negative fails the intended selective-invalidation assertion in both modes. The bank-inclusive stamp and every non-stamp flag match upstream exactly. Focused cache, bank-stamp and BC3 checks pass. No full-game build or throughput benchmark is claimed for this build-script change.
The ordinary merge includes main15ec and the merged #806 baseline correction. CI for this refreshed head is pending.