Repository navigation
test: match memory-trim checks to resized BC3 scratch uploads - #806
Merged
Merged
Conversation
This was referenced Nov 8, 2026
This was referenced Nov 8, 2026
This was referenced Nov 8, 2026
madebyjordan
added a commit
to madebyjordan/Longshot
that referenced
this pull request
Nov 9, 2026
Longshot tags a release after its build is played. The release workflow (semantic-release) only runs by hand, and the AppImage release job waits for vars.CI_RELEASE_LINUX like the Windows one: its AppImage would update from Hookshot's releases. CHANGELOG and PICKS updated (test fix from NotRexed#806). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BC3 upload paths now pass their resize mode to
bc_scratch_layout, buttest_mem_trim.pystill counts the old zero-argument call. The source check therefore fails on the released v2.0.5 code on both CI platforms.Check the actual ASTC upload and texture-copy functions separately. Each must return on scratch-allocation failure and pass its own texture's resize flag. The other memory-trim checks are preserved.
Validation: the strict runner passes on Windows and Linux. The unmodified v2.0.5 test reproduces the reported CI failure; removing either guard or replacing either resize argument with
falseis rejected by the updated check. No production code, native compiler or GPU is involved.