next/593/20241002/v1 #11858
Merged
next/593/20241002/v1 #11858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the call to SCDropCaps for packet processing threads. This logic in this function is required to setup packet processing even when the thread is provided by a library user, in which case Suricata should not be touching is capabilities. As SCDropCaps is currently a no-op its clear this feature needs to be (re)designed properly, taking into consideration library users as well. Related ticket: https://redmine.openinfosecfoundation.org/issues/2375
Unset ac_cv_header_hs_h before checking for header. This allows hyperscan to be included in compilation when switching from a non-hs build to a hs build.
Fix potential dereference of nullptr in case of unsuccessful allocation of memory for list node Bug: OISF#7270
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.6 to 3.26.10. - [Release notes](https://github.com/github/codeql-action/releases) - [Commits](github/codeql-action@v3.26.6...v3.26.10) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.5.0 to 4.6.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@e28ff12...b9fd7d1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.7 to 4.2.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@692973e...d632683) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
|
NOTE: This PR may contain new authors. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11858 +/- ##
==========================================
- Coverage 82.60% 82.56% -0.04%
==========================================
Files 912 912
Lines 249351 249354 +3
==========================================
- Hits 205965 205880 -85
- Misses 43386 43474 +88
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
|
Looks consistent with the approved PRs, let's wait for netmap CI retry |
catenacyber
approved these changes
Oct 2, 2024
Contributor
catenacyber
left a comment
catenacyber
left a comment
There was a problem hiding this comment.
Approving, but you may want to rerun the net map build
jasonish
approved these changes
Oct 2, 2024
|
Information: QA ran without warnings. Pipeline 22950 |
This was referenced Oct 2, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging: