fix: redis-cluster unexpected downscaling (#1167)

[xiaozhuang-a]

Description

1. ensure statefulset status is ready before scaling
2. failover command is not effective
3. return directly after failover command

Fixes #1167

Type of change

• Bug fix (non-breaking change which fixes an issue)

Checklist

• Tests have been added/modified and all tests pass.
• Functionality/bugs have been confirmed to be unchanged or fixed.
• I have performed a self-review of my own code.
• Documentation has been updated or added where necessary.

Additional Context

[xiaozhuang-a]

already self-test passed

[drivebyer]

@xiaozhuang-a please fix the failed check :)

[drivebyer]

We should retain the content from this commit in this PR. It seems the content was removed after resolving the conflict. @xiaozhuang-a

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 30.13%. Comparing base (60ef5a2) to head (64fb517).
Report is 7 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/k8sutils/cluster-scaling.go	0.00%	13 Missing ⚠️
...ontrollers/rediscluster/rediscluster_controller.go	0.00%	8 Missing ⚠️
pkg/k8sutils/poddisruption.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1171      +/-   ##
==========================================
- Coverage   30.20%   30.13%   -0.08%     
==========================================
  Files          55       55              
  Lines        6294     6309      +15     
==========================================
  Hits         1901     1901              
- Misses       4200     4215      +15     
  Partials      193      193              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[xiaozhuang-a]

We should retain the content from this commit in this PR. It seems the content was removed after resolving the conflict. @xiaozhuang-a

there are some issues with conflict merging, please allow me to bring up a new PR

[xiaozhuang-a]

We should retain the content from this commit in this PR. It seems the content was removed after resolving the conflict. @xiaozhuang-a

#1173