Skip to content

fix: redis-cluster unexpected downscaling (#1167)#1173

Merged
drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom
xiaozhuang-a:fix-downscaling
Dec 16, 2024
Merged

fix: redis-cluster unexpected downscaling (#1167)#1173
drivebyer merged 1 commit intoOT-CONTAINER-KIT:masterfrom
xiaozhuang-a:fix-downscaling

Conversation

@xiaozhuang-a
Copy link
Copy Markdown
Contributor

Description

  1. ensure statefulset status is ready before scaling
  2. failover command is not effective
  3. return directly after failover command

Fixes #1167

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 29.92%. Comparing base (60ef5a2) to head (8b86853).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
pkg/k8sutils/cluster-scaling.go 0.00% 13 Missing ⚠️
...ontrollers/rediscluster/rediscluster_controller.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1173      +/-   ##
==========================================
- Coverage   30.20%   29.92%   -0.28%     
==========================================
  Files          55       55              
  Lines        6294     6362      +68     
==========================================
+ Hits         1901     1904       +3     
- Misses       4200     4263      +63     
- Partials      193      195       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer enabled auto-merge (squash) December 16, 2024 13:28
Copy link
Copy Markdown
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drivebyer drivebyer merged commit d28caf1 into OT-CONTAINER-KIT:master Dec 16, 2024
xiaozhuang-a added a commit to xiaozhuang-a/redis-operator that referenced this pull request Dec 18, 2024
…-CONTAINER-KIT#1173)

Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
Co-authored-by: xiaozhuang <xiaozhuang@minimaxi.com>
Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
xiaozhuang-a added a commit to xiaozhuang-a/redis-operator that referenced this pull request Dec 18, 2024
…-CONTAINER-KIT#1173)

Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
Co-authored-by: xiaozhuang <xiaozhuang@minimaxi.com>
Signed-off-by: xiaozhuang <xiaozhuang@minimaxi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crash master after failover can cause unexpected downscaling

2 participants