Skip to content

Increase max message size#2938

Merged
jmthomas merged 1 commit into
mainfrom
ws_max_message_size
Mar 5, 2026
Merged

Increase max message size#2938
jmthomas merged 1 commit into
mainfrom
ws_max_message_size

Conversation

@ryanmelt
Copy link
Copy Markdown
Member

@ryanmelt ryanmelt commented Mar 5, 2026

This is temporary fix for command history to allow for lots of commands. The longer term fix will be to add an "ALL" option to subscribe to all commands.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.49%. Comparing base (3e325a7) to head (be185fb).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2938      +/-   ##
==========================================
+ Coverage   77.79%   78.49%   +0.70%     
==========================================
  Files         471      673     +202     
  Lines       34647    55277   +20630     
  Branches      728      728              
==========================================
+ Hits        26955    43392   +16437     
- Misses       7614    11807    +4193     
  Partials       78       78              
Flag Coverage Δ
python 79.74% <ø> (-16.30%) ⬇️
ruby-api 80.86% <ø> (+0.35%) ⬆️
ruby-backend 82.14% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 5, 2026

@ryanmelt ryanmelt requested a review from jmthomas March 5, 2026 20:38
@ryanmelt
Copy link
Copy Markdown
Member Author

ryanmelt commented Mar 5, 2026

Confirmed that this worked with 5000 commands in load_sim.

@ryanmelt
Copy link
Copy Markdown
Member Author

ryanmelt commented Mar 5, 2026

This change will likely work up to about 25000 commands in the system.

@jmthomas
Copy link
Copy Markdown
Member

jmthomas commented Mar 5, 2026

Longer term fix: #2940

@jmthomas jmthomas merged commit ebb7714 into main Mar 5, 2026
28 of 32 checks passed
@jmthomas jmthomas deleted the ws_max_message_size branch March 5, 2026 21:36
jmthomas added a commit that referenced this pull request Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants