Add ALL wildcard support to streaming API packet subscriptions#2940
Merged
Conversation
Allow clients to subscribe to all packets using ALL in place of target or packet name (e.g. DECOM__CMD__ALL__CONVERTED) instead of listing every packet individually. The server expands ALL into concrete packet keys at subscription time, skipping UNKNOWN targets/packets and silently skipping unauthorized packets. This reduces the subscription message from 1000+ entries to a single key for CommandHistory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jmthomas
commented
Mar 5, 2026
| type = (cmd_or_tlm == 'CMD') ? :CMD : :TLM | ||
| targets = OpenC3::TargetModel.names(scope: scope) | ||
| targets.each do |target_name| | ||
| next if target_name == 'UNKNOWN' |
Member
Author
There was a problem hiding this comment.
I added the filter for UNKNOWN because it was crashing the stream
Member
There was a problem hiding this comment.
UNKNOWN should be valid for RAW but not for DECOM.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2940 +/- ##
==========================================
+ Coverage 77.81% 78.47% +0.66%
==========================================
Files 453 673 +220
Lines 33986 55311 +21325
Branches 728 728
==========================================
+ Hits 26447 43407 +16960
- Misses 7461 11826 +4365
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ryanmelt
requested changes
Mar 5, 2026
| type = (cmd_or_tlm == 'CMD') ? :CMD : :TLM | ||
| targets = OpenC3::TargetModel.names(scope: scope) | ||
| targets.each do |target_name| | ||
| next if target_name == 'UNKNOWN' |
Member
There was a problem hiding this comment.
UNKNOWN should be valid for RAW but not for DECOM.
|
ryanmelt
approved these changes
Mar 6, 2026
jmthomas
added a commit
that referenced
this pull request
Mar 21, 2026
Add ALL wildcard support to streaming API packet subscriptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow clients to subscribe to all packets using ALL in place of target or packet name (e.g. DECOM__CMD__ALL__CONVERTED) instead of listing every packet individually. The server expands ALL into concrete packet keys at subscription time, skipping UNKNOWN targets/packets and silently skipping unauthorized packets. This reduces the subscription message from 1000+ entries to a single key for CommandHistory.