Skip to content

[workspace] Upgrade MOSEK to latest release 10.1.21 #20634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Dec 5, 2023

Closes #20628.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added the release notes: fix This pull request contains fixes (no new features) label Dec 5, 2023
@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot mac-arm-ventura-clang-bazel-experimental-everything-release please

@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot mac-x86-monterey-clang-bazel-experimental-everything-debug please

@jwnimmer-tri
Copy link
Collaborator Author

+@hongkai-dai for review / co-author, please. Do you have time to look into the test failure report? Feel free to directly push any fixups.

@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review December 5, 2023 20:56
Copy link
Contributor

@hongkai-dai hongkai-dai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: , I also relaxed the tolerance in the test.

Reviewed 10 of 10 files at r1.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)

Copy link
Contributor

@hongkai-dai hongkai-dai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@sherm1 for platform review please, thanks!

Reviewable status: LGTM missing from assignee sherm1(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is failing on the "everything" builds:

[RUN] MosekTest.MotzkinPolynomial
solvers/test/sos\_examples.cc:108: Failure
Value of: symbolic::test::PolynomialEqual( r\_result - symbolic::Polynomial(x\_ \* x\_ + y\_ \* y\_, {x\_, y\_}), monomial\_basis1\_.dot(gram1\_val \* monomial\_basis1\_), tol)
  Actual: false (The coefficient for x(0)^2 is -4.5817596383557202e-09, exceed tolerance 3e-09
)
Expected: true

solvers/test/sos\_examples.cc:111: Failure
Value of: symbolic::test::PolynomialEqual( m\_result \* r\_result, monomial\_basis2\_.dot(gram2\_val \* monomial\_basis2\_), tol)
  Actual: false (The coefficient for x(0)^4 \* x(0)^2 is -3.9486347525041765e-09, exceed tolerance 3e-09
)
Expected: true

[FAILED] MosekTest.MotzkinPolynomial (11 ms)

Reviewed 9 of 10 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee sherm1(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: pending CI fix

Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)

@hongkai-dai
Copy link
Contributor

@drake-jenkins-bot mac-x86-monterey-clang-bazel-experimental-everything-debug please

Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)

@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot mac-arm-ventura-clang-bazel-experimental-everything-release please

@jwnimmer-tri jwnimmer-tri added the status: squashing now https://drake.mit.edu/reviewable.html#curated-commits label Dec 7, 2023
@jwnimmer-tri
Copy link
Collaborator Author

@hongkai-dai looks like we need 1 more tolerance bump, perhaps?

Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees sherm1(platform),hongkai-dai

@jwnimmer-tri
Copy link
Collaborator Author

@drake-jenkins-bot mac-arm-ventura-clang-bazel-experimental-everything-release please

@hongkai-dai hongkai-dai merged commit 596729b into RobotLocomotion:master Dec 7, 2023
@jwnimmer-tri jwnimmer-tri deleted the mosek-10.1 branch December 7, 2023 20:09
ggould-tri pushed a commit to ggould-tri/drake that referenced this pull request Dec 11, 2023
…20634)

[workspace] Upgrade MOSEK to latest release 10.1.21

---------

Co-authored-by: Hongkai Dai <[email protected]>
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 27, 2023
…20634)

[workspace] Upgrade MOSEK to latest release 10.1.21

---------

Co-authored-by: Hongkai Dai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: fix This pull request contains fixes (no new features) status: squashing now https://drake.mit.edu/reviewable.html#curated-commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Mosek to 10.1
3 participants