-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[workspace] Upgrade MOSEK to latest release 10.1.21 #20634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@drake-jenkins-bot mac-arm-ventura-clang-bazel-experimental-everything-release please |
@drake-jenkins-bot mac-x86-monterey-clang-bazel-experimental-everything-debug please |
+@hongkai-dai for review / co-author, please. Do you have time to look into the test failure report? Feel free to directly push any fixups. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
, I also relaxed the tolerance in the test.
Reviewed 10 of 10 files at r1.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@sherm1 for platform review please, thanks!
Reviewable status: LGTM missing from assignee sherm1(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is failing on the "everything" builds:
[RUN] MosekTest.MotzkinPolynomial
solvers/test/sos\_examples.cc:108: Failure
Value of: symbolic::test::PolynomialEqual( r\_result - symbolic::Polynomial(x\_ \* x\_ + y\_ \* y\_, {x\_, y\_}), monomial\_basis1\_.dot(gram1\_val \* monomial\_basis1\_), tol)
Actual: false (The coefficient for x(0)^2 is -4.5817596383557202e-09, exceed tolerance 3e-09
)
Expected: true
solvers/test/sos\_examples.cc:111: Failure
Value of: symbolic::test::PolynomialEqual( m\_result \* r\_result, monomial\_basis2\_.dot(gram2\_val \* monomial\_basis2\_), tol)
Actual: false (The coefficient for x(0)^4 \* x(0)^2 is -3.9486347525041765e-09, exceed tolerance 3e-09
)
Expected: true
[FAILED] MosekTest.MotzkinPolynomial (11 ms)
Reviewed 9 of 10 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee sherm1(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)
@drake-jenkins-bot mac-x86-monterey-clang-bazel-experimental-everything-debug please |
11226d8
to
94c2b20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jwnimmer-tri)
@drake-jenkins-bot mac-arm-ventura-clang-bazel-experimental-everything-release please |
@hongkai-dai looks like we need 1 more tolerance bump, perhaps? |
94c2b20
to
b9fbbfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees sherm1(platform),hongkai-dai
@drake-jenkins-bot mac-arm-ventura-clang-bazel-experimental-everything-release please |
…20634) [workspace] Upgrade MOSEK to latest release 10.1.21 --------- Co-authored-by: Hongkai Dai <[email protected]>
…20634) [workspace] Upgrade MOSEK to latest release 10.1.21 --------- Co-authored-by: Hongkai Dai <[email protected]>
Closes #20628.
This change is