Skip to content

[doc] Geometry "supported file formats" explains ktx2 textures #21193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Mar 26, 2024

We also refresh some glTF-related details (e.g., VTK support).

Towards #20935.

+@SeanCurtis-TRI for both(?) reviews, please.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: none This pull request should not be mentioned in the release notes labels Mar 26, 2024
Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM: X2

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion


geometry/geometry_file_formats_doxygen.h line 231 at r1 (raw file):

 For best performance, we recommend that meshes destined for the Illustration
 role use the KHR_texture_basisu extension, where textures are stored using the

BTW This one also seems deserving of a cross link.

https://github.com/KhronosGroup/glTF/blob/main/extensions/2.0/Khronos/KHR_texture_basisu/README.md

We also refresh some glTF-related details (e.g., VTK support).
Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform)

@jwnimmer-tri jwnimmer-tri merged commit 60b12bf into RobotLocomotion:master Mar 26, 2024
@jwnimmer-tri jwnimmer-tri deleted the gff-ktx2 branch March 26, 2024 19:17
RussTedrake pushed a commit to RussTedrake/drake that referenced this pull request Dec 15, 2024
…Locomotion#21193)

We also refresh some glTF-related details (e.g., VTK support).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants