Skip to content

[workspace] Upgrade googlebenchmark to latest release v1.9.2 #22854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Aiden2244
Copy link
Contributor

@Aiden2244 Aiden2244 commented Apr 2, 2025

Towards #22836

This commit had problematic output in local testing and caused CI jobs to fail. Most recent CI run passed locally, but will await Jenkins ci builds for confirmation.

It would appear these upgrades are indeed problematic: linux-jammy-clang-bazel-experimental-everything-release


This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator

This requires either +@rpoyner-tri or myself +@jwnimmer-tri to rebase our console_allocs.patch for the new upstream.

@jwnimmer-tri jwnimmer-tri added the release notes: fix This pull request contains fixes (no new features) label Apr 3, 2025
Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r2 updates the patch. Let's see what CI says.

Reviewable status: LGTM missing from assignees rpoyner-tri(platform),jwnimmer-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @Aiden2244)

@jwnimmer-tri jwnimmer-tri added status: single reviewer ok https://drake.mit.edu/reviewable.html and removed status: do not review labels Apr 6, 2025
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: tested locally.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @Aiden2244)

@jwnimmer-tri jwnimmer-tri merged commit 7196af6 into RobotLocomotion:master Apr 6, 2025
10 of 11 checks passed
@Aiden2244 Aiden2244 deleted the upgrades-googlebenchmark-fix branch April 10, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: fix This pull request contains fixes (no new features) status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants