Suppress benign eXIf warnings from libpng 1.6.47 #22861
Conversation
There was a problem hiding this comment.
+@jwnimmer-tri +@BetsyMcPhail for feature review please.
Reviewable status: LGTM missing from assignees jwnimmer-tri(platform),BetsyMcPhail, missing label for release notes (waiting on @Aiden2244)
There was a problem hiding this comment.
Is it possible to combine this change with #22862 so that CI can confirm that the warnings are suppressed?
Reviewable status: LGTM missing from assignees jwnimmer-tri(platform),BetsyMcPhail, missing label for release notes (waiting on @Aiden2244)
There was a problem hiding this comment.
Done! Added to this pr as two separate commits.
Reviewable status: LGTM missing from assignees jwnimmer-tri(platform),BetsyMcPhail, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits), missing label for release notes (waiting on @Aiden2244)
There was a problem hiding this comment.
Locally, I ran bazel test //geometry/render_vtk:internal_render_engine_vtk_test --test_output=streamed and confirmed the warnings no longer appeared.
-@jwnimmer-tri +@sammy-tri for platform review per schedule.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee sammy-tri(platform), commits need curation (https://drake.mit.edu/reviewable.html#curated-commits), missing label for release notes (waiting on @Aiden2244)
jwnimmer-tri
added
the
release notes: fix
sammy-tri
added
the
status: commits are properly curated
There was a problem hiding this comment.
+(status: commits are properly curated)
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: when planning a "properly curated" merge commit the PR must always be rebased onto latest master (waiting on @Aiden2244)
sammy-tri
added
status: squashing now
There was a problem hiding this comment.
-(status: commits are properly curated) +(status: squashing now)
Reviewable status: when planning a "properly curated" merge commit the PR must always be rebased onto latest master (waiting on @Aiden2244)
Closes #22728, unblocks #22862, and towards #22836
Modifies list of custom, drake-specific adjustments to libpng to disable eXIf read support. Disabling this option effectively suppresses the
libpng warning: eXIf: invalidoutput that we would observe running the drake vtk rendering tests on Linux. As eXIf chunks are optional and tend to contain image metadata (particularly metadata relevant to images taken with physical cameras, e.g. aperture and shutter speed), reads for these kinds of chunks can be safely disabled for the rendered test images used for this test suite.This change is