Skip to content

Correct and improve rpy_ball_mobilizer documentation, replace E matrix with standard N matrix. #23006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mitiguy
Copy link
Contributor

@mitiguy mitiguy commented May 14, 2025

This is one in a series of PRs to help address issue #22630. It updates documentation in rpy_ball_mobilizer.cc and replaces an inconsistent "E" matrix notation with the "N" matrix.

This PR is in preparation for implementation of CalcNDotMatrix(), CalcNplusDotMatrix(), MapQDDotToAcceleration() and MapAccelerationToQDDot() in the rpy_ball_mobilizer class as was done in PR #22698 and PR #22950.

FYI: Since mobilizers are Drake internal classes, after the internal mobilizer work is complete, there will be PRs (code and testing) for the public API in MultibodyPlant to address issue #22630.


This change is Reviewable

@mitiguy mitiguy added priority: medium status: do not review status: single reviewer ok https://drake.mit.edu/reviewable.html release notes: none This pull request should not be mentioned in the release notes labels May 14, 2025
@mitiguy mitiguy changed the title [WIP] Update documentation. Replace E matrix with standard N matrix in rpy mobilizer. [WIP] Correct and improve rpy_ball_mobilizer documentation, replace E matrix with standard N matrix. May 14, 2025
@mitiguy mitiguy changed the title [WIP] Correct and improve rpy_ball_mobilizer documentation, replace E matrix with standard N matrix. Correct and improve rpy_ball_mobilizer documentation, replace E matrix with standard N matrix. May 14, 2025
Copy link
Contributor Author

@mitiguy mitiguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feature review +@sherm1

Reviewable status: LGTM missing from assignee sherm1(platform)

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Feature + platform :lgtm: pending a few comments

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 5 unresolved discussions


multibody/tree/rpy_ball_mobilizer.cc line 141 at r1 (raw file):

  // the mobilizer F frame, expressed in the F frame.
  //
  // ⌈ ṙ̇ ⌉   ⌈          cos(y) / cos(p),           sin(y) / cos(p),  0 ⌉ ⌈ ω0 ⌉

BTW this looks like rdotdot on my screen rather than rdot. Not sure if that's just a display artifact -- please check. Everything else looks like a single dot.


multibody/tree/rpy_ball_mobilizer.cc line 189 at r1 (raw file):

  // the mobilizer F frame, expressed in the F frame (thus w_FM_F = N⁺(q) * q̇).
  //
  // ⌈ ω0 ⌉   ⌈ cos(y) * cos(p),  -sin(y),  0 ⌉ ⌈ ṙ̇ ⌉

BTW again the rdot here looks like rdotdot(r̈) rather than (ṙ), while the rdot four lines up looks fine. Could be a display artifact but might really be dotdot?


multibody/tree/rpy_ball_mobilizer.cc line 211 at r1 (raw file):

  // the mobilizer F frame, expressed in the F frame.
  //
  // ⌈ ṙ̇ ⌉   ⌈          cos(y) / cos(p),           sin(y) / cos(p),  0 ⌉ ⌈ ω0 ⌉

BTW dot dot?

Also, this seems to duplicate the comments above. If so, just write once and reference elsewhere.


multibody/tree/rpy_ball_mobilizer.cc line 259 at r1 (raw file):

  // invert the simpler equation v = N⁺(q) * q̇, whose matrix form is
  //
  // ⌈ ω0 ⌉   ⌈ cos(y) * cos(p),  -sin(y),  0 ⌉ ⌈ ṙ̇ ⌉

BTW dotdot?


multibody/tree/rpy_ball_mobilizer.cc line 280 at r1 (raw file):

  // the mobilizer F frame, expressed in the F frame (thus w_FM_F = N⁺(q) * q̇).
  //
  // ⌈ ω0 ⌉   ⌈ cos(y) * cos(p),  -sin(y),  0 ⌉ ⌈ ṙ̇ ⌉

BTW dotdot?

@mitiguy mitiguy force-pushed the rpyMobilizerReplaceEmatrixWithStandardNmatrix branch from 27d7113 to c747ebf Compare May 14, 2025 20:30
Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 1 unresolved discussion, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @mitiguy)

Copy link
Contributor Author

@mitiguy mitiguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)


multibody/tree/rpy_ball_mobilizer.cc line 141 at r1 (raw file):

Previously, sherm1 (Michael Sherman) wrote…

BTW this looks like rdotdot on my screen rather than rdot. Not sure if that's just a display artifact -- please check. Everything else looks like a single dot.

Done.


multibody/tree/rpy_ball_mobilizer.cc line 189 at r1 (raw file):

Previously, sherm1 (Michael Sherman) wrote…

BTW again the rdot here looks like rdotdot(r̈) rather than (ṙ), while the rdot four lines up looks fine. Could be a display artifact but might really be dotdot?

Done.


multibody/tree/rpy_ball_mobilizer.cc line 211 at r1 (raw file):

Previously, sherm1 (Michael Sherman) wrote…

BTW dot dot?

Also, this seems to duplicate the comments above. If so, just write once and reference elsewhere.

Done.


multibody/tree/rpy_ball_mobilizer.cc line 259 at r1 (raw file):

Previously, sherm1 (Michael Sherman) wrote…

BTW dotdot?

Done.


multibody/tree/rpy_ball_mobilizer.cc line 280 at r1 (raw file):

Previously, sherm1 (Michael Sherman) wrote…

BTW dotdot?

Done.

@mitiguy mitiguy added the status: squashing now https://drake.mit.edu/reviewable.html#curated-commits label May 14, 2025
Copy link
Contributor Author

@mitiguy mitiguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+(status: squashing now)

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee sherm1(platform)

@mitiguy mitiguy merged commit cd5a142 into RobotLocomotion:master May 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium release notes: none This pull request should not be mentioned in the release notes status: single reviewer ok https://drake.mit.edu/reviewable.html status: squashing now https://drake.mit.edu/reviewable.html#curated-commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants