Skip to content

alpha: expose underlying nitro configuration in vite plugin #4192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: alpha
Choose a base branch
from

Conversation

MoeedDar
Copy link
Contributor

I was having some build issues across multiple platforms - I figured I'd have a better chance of resolving them if the nitro config was exposed.

Any edge cases I might be missing here? Wondering why this was omitted in the first place.

Copy link

nx-cloud bot commented May 17, 2025

View your CI Pipeline Execution ↗ for commit 274819a.

Command Status Duration Result
nx run-many --targets=test:eslint,test:unit,tes... ✅ Succeeded 5m 38s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-05 20:27:28 UTC

Copy link

pkg-pr-new bot commented May 17, 2025

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@4192

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@4192

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@4192

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@4192

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@4192

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@4192

@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@4192

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@4192

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@4192

@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@4192

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@4192

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@4192

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@4192

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@4192

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@4192

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@4192

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@4192

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@4192

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@4192

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@4192

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@4192

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@4192

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@4192

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@4192

@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@4192

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@4192

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@4192

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@4192

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@4192

@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@4192

@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@4192

@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@4192

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@4192

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@4192

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@4192

commit: 274819a

@schiller-manuel
Copy link
Contributor

schiller-manuel commented May 17, 2025

we will not expose nitro options anymore
what exactly were you missing?

@ryoppippi
Copy link

ryoppippi commented May 17, 2025

Related to this?
#4193

@MoeedDar
Copy link
Contributor Author

we will not expose nitro options anymore what exactly were you missing?

I think at least exposing the cloudflare + vercel preset options along with the rollup options would be helpful
I was getting different errors between vercel/netlify/cloudflare - it would be nice to have more leeway to tweak things around and try and fix the build issues.

@MoeedDar
Copy link
Contributor Author

Related to this? #4193

I was getting this issue:
image
Uenv seems like the fix?

@MoeedDar
Copy link
Contributor Author

It would also be nice to have access to websockets via nitro - I don't think the server will accept websocket requests without experimental.websockets = true

@ryoppippi
Copy link

ryoppippi commented May 17, 2025

you can access 'cloudflare:*' import from your code, but you have to externalised the module like

	build: {
		rollupOptions: {
			external: [
				'cloudflare:sockets',
			],
		},
	},

in vite.config

@MoeedDar
Copy link
Contributor Author

didn't change a thing unfortunately - tried externalising postgres too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants