alpha: export unenv option #4193
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, we can include unenv in this plugin and automatically set cloudflare's unenv when target is for cloudflare |
|
we will not expose nitro options for building. we are investigating how we can properly support cloudflare |
|
Oh okay, so if I can help you let me know |
|
I just want to use it on CF worker! |
|
I tested that |
did you need to make any changes or did this work out of the box? i'm having issues, so if you have a repo of that test that'd be greatly appreciated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to test alpha with cloudflare workers so I created this PR
This pull request introduces support for a new
unenvoption in thenitroPluginand updates the schema to validate this new option. The changes ensure that theunenvconfiguration is properly passed and handled throughout the plugin.Addition of
unenvoption:packages/start-plugin-core/src/nitro/nitro-plugin.ts: Added a newunenvoption to thenitroPluginfunction, making it configurable via theoptionsparameter. Theunenvvalue is also passed to theprerenderconfiguration. [1] [2]Schema update:
packages/start-plugin-core/src/schema.ts: Updated the schema increateTanStackStartOptionsSchemato include theunenvoption, ensuring it is validated as part of the plugin's configuration.