Skip to content

Always update (allow for controlled components)#80

Open
bvandenbos wants to merge 7 commits into
airbnb:masterfrom
bvandenbos:controlled
Open

Always update (allow for controlled components)#80
bvandenbos wants to merge 7 commits into
airbnb:masterfrom
bvandenbos:controlled

Conversation

@bvandenbos
Copy link
Copy Markdown

Proposed fix for #76.

Copy link
Copy Markdown
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to the reasons this code was there in the first place, but in order for this change to be made, we'd need to add a test that covered it, to prevent regressions.

@bvandenbos
Copy link
Copy Markdown
Author

Yup - adding that now. Thanks.

@bvandenbos
Copy link
Copy Markdown
Author

Updated original test to reflect new behavior. Code coverage is complaining because the removed lines were covered which shifts the % down slightly. That can be addressed if folks agree this change actually makes sense.

@jpke
Copy link
Copy Markdown

jpke commented Jun 28, 2017

Any word on when this can be incorporated? It would help me out!

@ljharb
Copy link
Copy Markdown
Collaborator

ljharb commented Jun 28, 2017

This will need a rebase on the command line - the "update branch" button adds a merge commit, unfortunately.

@ljharb
Copy link
Copy Markdown
Collaborator

ljharb commented Jun 29, 2017

It looks like you rebased your merged branch on top of your fork's master, instead of on top of this repo's master - I'll rebase it for you now.

@bvandenbos
Copy link
Copy Markdown
Author

thanks - sorry realized that and then got pulled away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants